758824 - Updates to tamarin test suite from falcon.

Status: RESOLVED FIXED

(Tamarin Graveyard :: Tools, defect)

Description

[Chris Peyer]

Attachment: Updates to the testsuite from falcon.

This patch is a collection of minor test modifications and test/testcase additions that were made to the falcon tamarin acceptance tests.

Comment 1

[Brent Baker]

Comment on attachment 627401 [details] [diff] [review]
Updates to the testsuite from falcon.

Review of attachment 627401 [details] [diff] [review]:
-----------------------------------------------------------------

I'll address my comments and get this patch landed. It is currently running through a sandbox build now.

::: test/acceptance/as3/ShellClasses/ByteArray.as
@@ +1,1 @@
> +/* ***** BEGIN LICENSE BLOCK *****

Note to self: is this just a copy of other ByteArray media? Is this necessary?

::: test/acceptance/as3/Vector/interfaceMethodReturnType.as
@@ +45,5 @@
> +   built-in join method were invoiked for this object
> +   with no argument.
> +   Author:             [e-mail] 7-Oct-1997
> +   Updated:            [e-mail] 1-Nov-2007
> +*/

This documentation block seems incorrect (cute/paste error)

::: test/acceptance/as3/Vector/staticInitializer.as
@@ +46,5 @@
> +   with no argument.
> +   Author:             [e-mail] 7-Oct-1997
> +   Updated:            [e-mail] 1-Nov-2007
> +*/
> + 

This documentation block seems incorrect (cute/paste error)

Comment 2

[Brent Baker]

Attachment: Updates to the testsuite from falcon.

Chris do you know what was done to the ByteArray test? I know that we have moved the test (as3/ByteArray/ByteArray.as) and have also done a lot of reworking of the testcase to clean up the code. Just wondering if you happen to have a diff locally that shows your changes so that I can apply them to the current code.

Comment 3

[Brent Baker]

(In reply to Brent Baker from comment #2)
> Created attachment 644984 [details] [diff] [review]
> Updates to the testsuite from falcon.
> 
> Chris do you know what was done to the ByteArray test? I know that we have
> moved the test (as3/ByteArray/ByteArray.as) and have also done a lot of
> reworking of the testcase to clean up the code. Just wondering if you happen
> to have a diff locally that shows your changes so that I can apply them to
> the current code.

It actually looks like you didn't have any change to the ByteArray file as it is an exact copy of
http://hg.mozilla.org/tamarin-redux/file/4554d2fb1918/test/acceptance/as3/ShellClasses/ByteArray.as

So I am going to remove the byteArray changes from the patch and commit the lastest version based on my comments.

Comment 4

[Brent Baker]

Attachment: v3. Updates to the testsuite from falcon.

Comment 5

[Tamarin Bot]

changeset: 7502:b1f795255e16
user:      Brent Baker <[e-mail]>
summary:   Bug 758824: Updates to tamarin test suite from falcon. (p=cpeyer, r=brbaker)

http://hg.mozilla.org/tamarin-redux/rev/b1f795255e16