Updates to tamarin test suite from falcon.

RESOLVED FIXED

Status

Tamarin
Tools
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: Chris Peyer, Assigned: Brent Baker)

Tracking

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

6 years ago
Created attachment 627401 [details] [diff] [review]
Updates to the testsuite from falcon.

This patch is a collection of minor test modifications and test/testcase additions that were made to the falcon tamarin acceptance tests.
Attachment #627401 - Flags: review?(brbaker)
(Assignee)

Comment 1

6 years ago
Comment on attachment 627401 [details] [diff] [review]
Updates to the testsuite from falcon.

Review of attachment 627401 [details] [diff] [review]:
-----------------------------------------------------------------

I'll address my comments and get this patch landed. It is currently running through a sandbox build now.

::: test/acceptance/as3/ShellClasses/ByteArray.as
@@ +1,1 @@
> +/* ***** BEGIN LICENSE BLOCK *****

Note to self: is this just a copy of other ByteArray media? Is this necessary?

::: test/acceptance/as3/Vector/interfaceMethodReturnType.as
@@ +45,5 @@
> +   built-in join method were invoiked for this object
> +   with no argument.
> +   Author:             christine@netscape.com 7-Oct-1997
> +   Updated:            dschaffe@adobe.com 1-Nov-2007
> +*/

This documentation block seems incorrect (cute/paste error)

::: test/acceptance/as3/Vector/staticInitializer.as
@@ +46,5 @@
> +   with no argument.
> +   Author:             christine@netscape.com 7-Oct-1997
> +   Updated:            dschaffe@adobe.com 1-Nov-2007
> +*/
> + 

This documentation block seems incorrect (cute/paste error)
Attachment #627401 - Flags: review?(brbaker) → review+
(Assignee)

Updated

6 years ago
QA Contact: brbaker
(Assignee)

Comment 2

6 years ago
Created attachment 644984 [details] [diff] [review]
Updates to the testsuite from falcon.

Chris do you know what was done to the ByteArray test? I know that we have moved the test (as3/ByteArray/ByteArray.as) and have also done a lot of reworking of the testcase to clean up the code. Just wondering if you happen to have a diff locally that shows your changes so that I can apply them to the current code.
Assignee: nobody → brbaker
Attachment #627401 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #644984 - Flags: review?(cpeyer)
(Assignee)

Comment 3

6 years ago
(In reply to Brent Baker from comment #2)
> Created attachment 644984 [details] [diff] [review]
> Updates to the testsuite from falcon.
> 
> Chris do you know what was done to the ByteArray test? I know that we have
> moved the test (as3/ByteArray/ByteArray.as) and have also done a lot of
> reworking of the testcase to clean up the code. Just wondering if you happen
> to have a diff locally that shows your changes so that I can apply them to
> the current code.

It actually looks like you didn't have any change to the ByteArray file as it is an exact copy of
http://hg.mozilla.org/tamarin-redux/file/4554d2fb1918/test/acceptance/as3/ShellClasses/ByteArray.as

So I am going to remove the byteArray changes from the patch and commit the lastest version based on my comments.
(Assignee)

Comment 4

6 years ago
Created attachment 644993 [details] [diff] [review]
v3. Updates to the testsuite from falcon.
Attachment #644984 - Attachment is obsolete: true
Attachment #644984 - Flags: review?(cpeyer)

Comment 5

5 years ago
changeset: 7502:b1f795255e16
user:      Brent Baker <brbaker@adobe.com>
summary:   Bug 758824: Updates to tamarin test suite from falcon. (p=cpeyer, r=brbaker)

http://hg.mozilla.org/tamarin-redux/rev/b1f795255e16
(Assignee)

Updated

5 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.