Note: There are a few cases of duplicates in user autocompletion which are being worked on.

TableTicker isn't destroyed when profiler is stopped

RESOLVED FIXED in mozilla15

Status

()

Core
Gecko Profiler
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mstange, Assigned: Ehsan)

Tracking

({mlk})

Trunk
mozilla15
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
http://hg.mozilla.org/mozilla-central/annotate/cff5b4470690/tools/profiler/TableTicker.cpp#l783

void mozilla_sampler_stop()
{
  TableTicker *t = tlsTicker.get();
  if (!t) {
    return;
  }

  t->Stop();
  tlsTicker.set(NULL);
}

I think there's a "delete t;" missing here.

Maybe this is the state we leave behind which causes bug 737328.
(Reporter)

Updated

5 years ago
Summary: TableTicker isn't destroyed when profile is stopped → TableTicker isn't destroyed when profiler is stopped
Keywords: mlk
Created attachment 628943 [details] [diff] [review]
Patch (v1)
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #628943 - Flags: review?(bgirard)
I don't see how this would help bug 737328.

Updated

5 years ago
Attachment #628943 - Flags: review?(bgirard) → review+
(In reply to Benoit Girard (:BenWa) from comment #2)
> I don't see how this would help bug 737328.

It won't, unless you believe in magic.  ;-)
https://hg.mozilla.org/integration/mozilla-inbound/rev/2b3fc9837fea
Target Milestone: --- → mozilla15

Comment 5

5 years ago
https://hg.mozilla.org/mozilla-central/rev/2b3fc9837fea
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.