758890 - TableTicker isn't destroyed when profiler is stopped

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect)

Description

[Markus Stange [:mstange]]

http://hg.mozilla.org/mozilla-central/annotate/cff5b4470690/tools/profiler/TableTicker.cpp#l783

void mozilla_sampler_stop()
{
  TableTicker *t = tlsTicker.get();
  if (!t) {
    return;
  }

  t->Stop();
  tlsTicker.set(NULL);
}

I think there's a "delete t;" missing here.

Maybe this is the state we leave behind which causes bug 737328.

Comment 1

[(no longer active)]

Attachment: Patch (v1)

Comment 2

[Benoit Girard (:BenWa)]

I don't see how this would help bug 737328.

Comment 3

[(no longer active)]

(In reply to Benoit Girard (:BenWa) from comment #2)
> I don't see how this would help bug 737328.

It won't, unless you believe in magic.  ;-)

Comment 4

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2b3fc9837fea

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/2b3fc9837fea