Last Comment Bug 758890 - TableTicker isn't destroyed when profiler is stopped
: TableTicker isn't destroyed when profiler is stopped
Status: RESOLVED FIXED
: mlk
Product: Core
Classification: Components
Component: Gecko Profiler (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla15
Assigned To: :Ehsan Akhgari
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-05-26 09:32 PDT by Markus Stange [:mstange]
Modified: 2012-06-01 08:09 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (v1) (478 bytes, patch)
2012-05-31 16:15 PDT, :Ehsan Akhgari
bgirard: review+
Details | Diff | Splinter Review

Description Markus Stange [:mstange] 2012-05-26 09:32:03 PDT
http://hg.mozilla.org/mozilla-central/annotate/cff5b4470690/tools/profiler/TableTicker.cpp#l783

void mozilla_sampler_stop()
{
  TableTicker *t = tlsTicker.get();
  if (!t) {
    return;
  }

  t->Stop();
  tlsTicker.set(NULL);
}

I think there's a "delete t;" missing here.

Maybe this is the state we leave behind which causes bug 737328.
Comment 1 :Ehsan Akhgari 2012-05-31 16:15:16 PDT
Created attachment 628943 [details] [diff] [review]
Patch (v1)
Comment 2 Benoit Girard (:BenWa) 2012-05-31 16:28:55 PDT
I don't see how this would help bug 737328.
Comment 3 :Ehsan Akhgari 2012-05-31 16:36:57 PDT
(In reply to Benoit Girard (:BenWa) from comment #2)
> I don't see how this would help bug 737328.

It won't, unless you believe in magic.  ;-)
Comment 5 Ed Morley [:emorley] 2012-06-01 08:09:58 PDT
https://hg.mozilla.org/mozilla-central/rev/2b3fc9837fea

Note You need to log in before you can comment on or make changes to this bug.