75895 - make clean dies on Mac OSX

Status: VERIFIED FIXED

(SeaMonkey :: Build Config, defect, P5)

Description

[Dave Alverson]

I believe its an anomoly in the rm program on osx/darwin.  If you do "rm -rf"
(no file or directory) it prints an error message and returns error status 1.
This happens in directories where ALL_TRASH_DIRS is empty, like build.  I put a
dash in front of the first rm command in the clean and distclean rules in
rules.mk.  It seems to like a space between the - and rm.  With the line
continuation, I think its only needed on the first line.

Comment 1

[Zach Lipton [:zach]]

pinkerton: can you confirm this?

Comment 2

[Mike Pinkerton (not reading bugmail)]

oh yes, i see it too. i was convinced it was my stuff that broke it, but i was 
overjoyed to discover that a clean pull has the same troubles.

Comment 3

[cls]

So what you're looking for is this?

Index: config/rules.mk
===================================================================
RCS file: /cvsroot/mozilla/config/rules.mk,v
retrieving revision 3.268
diff -u -r3.268 rules.mk
--- rules.mk    2001/04/05 03:36:56     3.268
+++ rules.mk    2001/04/13 22:02:14
@@ -586,7 +586,7 @@
        viewer
 
 clean clobber realclean clobber_all:: $(SUBMAKEFILES)
-       rm -f $(ALL_TRASH); \
+       -rm -f $(ALL_TRASH); \
        rm -rf $(ALL_TRASH_DIRS)
        +$(LOOP_OVER_DIRS)
        +$(LOOP_OVER_EXPORT_DIRS)
@@ -594,9 +594,9 @@
 distclean:: $(SUBMAKEFILES)
        +$(LOOP_OVER_DIRS)
        +$(LOOP_OVER_EXPORT_DIRS)
-       rm -f $(ALL_TRASH) ; \
+       -rm -f $(ALL_TRASH) ; \
        rm -rf $(ALL_TRASH_DIRS) ;
-       rm -rf $(wildcard *.map) \
+       -rm -rf $(wildcard *.map) \
        Makefile .HSancillary \
        $(wildcard *.$(OBJ_SUFFIX)) $(wildcard *.ho) \
        $(wildcard *.$(LIB_SUFFIX)) $(wildcard *$(DLL_SUFFIX))

Comment 4

[Dave Alverson]

Yes, that works for me.  Forget my comment about putting a space between the dash 
and the rm.  I initially put the dash on the first and second rm lines, and it 
didn't like it on the second line, because it was a continuation.

Comment 5

[Dave Alverson]

I have found another Makefile that needs a similar fix:

Index: mozilla/directory/c-sdk/ldap/build/Makefile.in
===================================================================
RCS file: /cvsroot/mozilla/directory/c-sdk/ldap/build/Attic/Makefile.in,v
retrieving revision 1.1.2.5
diff -u -r1.1.2.5 Makefile.in
--- mozilla/directory/c-sdk/ldap/build/Makefile.in      2001/04/13 23:35:11    
1.1.2.5
+++ mozilla/directory/c-sdk/ldap/build/Makefile.in      2001/04/24 14:27:36
@@ -32,5 +32,5 @@
 install:: export
 
 clean::
-       rm -rf $(filter-out . ..,$(OBJDIR_NAME))
+       -rm -rf $(filter-out . ..,$(OBJDIR_NAME))

Comment 6

[cls]

Patches have been checked in.

Comment 7

[Chris Petersen]

Marking verified per last comments.