convert mail/components/activity/*.js to Services.jsm and MailServices.js

RESOLVED FIXED in Thunderbird 15.0

Status

Thunderbird
Mail Window Front End
--
minor
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: aceman, Assigned: aceman)

Tracking

(Blocks: 2 bugs)

Trunk
Thunderbird 15.0
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

18.50 KB, patch
aceman
: review+
Details | Diff | Splinter Review
Comment hidden (empty)
(Assignee)

Comment 1

5 years ago
Oh, here is the description:
alertHook.js:    return this.brandShortName = Cc["@mozilla.org/intl/stringbundle;1"]
alertHook.js:    let msgMailSession = Cc["@mozilla.org/messenger/services/session;1"]
autosync.js:    let bundleSvc = Cc["@mozilla.org/intl/stringbundle;1"]
glodaIndexer.js:    let bundleSvc = Cc["@mozilla.org/intl/stringbundle;1"]
moveCopy.js:    let bundleSvc = Cc["@mozilla.org/intl/stringbundle;1"]
moveCopy.js:    let acctMgr = Components.classes["@mozilla.org/messenger/account-manager;1"]
moveCopy.js:    let notificationService = Components.classes["@mozilla.org/messenger/msgnotificationservice;1"]
pop3Download.js:    let bundleSvc = Cc["@mozilla.org/intl/stringbundle;1"]
pop3Download.js:    pop3Service = Cc["@mozilla.org/messenger/popservice;1"]
sendLater.js:    let bundleSvc = Cc["@mozilla.org/intl/stringbundle;1"]
(Assignee)

Comment 2

5 years ago
Created attachment 627565 [details] [diff] [review]
patch

Standard8, who could review this? It should be solely in the Activity manager.
Attachment #627565 - Flags: review?(mbanner)
Attachment #627565 - Flags: review?(mbanner) → review+
Comment on attachment 627565 [details] [diff] [review]
patch

Oh, I forgot to say there's a little bit of bitrot in nsActivityManagerUI.js due to the license change.
(Assignee)

Comment 4

5 years ago
Created attachment 628832 [details] [diff] [review]
patch v2

MPL2 bitrot.

Thanks for review.
Attachment #627565 - Attachment is obsolete: true
Attachment #628832 - Flags: review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
Landed in comm-central as https://hg.mozilla.org/comm-central/rev/828283ec0419
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 15.0
You need to log in before you can comment on or make changes to this bug.