Last Comment Bug 758951 - convert mail/components/activity/*.js to Services.jsm and MailServices.js
: convert mail/components/activity/*.js to Services.jsm and MailServices.js
Status: RESOLVED FIXED
:
Product: Thunderbird
Classification: Client Software
Component: Mail Window Front End (show other bugs)
: Trunk
: All All
: -- minor (vote)
: Thunderbird 15.0
Assigned To: :aceman
:
Mentors:
Depends on:
Blocks: 720356 720358
  Show dependency treegraph
 
Reported: 2012-05-27 05:59 PDT by :aceman
Modified: 2012-05-31 12:18 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch (18.71 KB, patch)
2012-05-27 07:52 PDT, :aceman
standard8: review+
Details | Diff | Splinter Review
patch v2 (18.50 KB, patch)
2012-05-31 11:37 PDT, :aceman
acelists: review+
Details | Diff | Splinter Review

Description :aceman 2012-05-27 05:59:27 PDT

    
Comment 1 :aceman 2012-05-27 06:02:55 PDT
Oh, here is the description:
alertHook.js:    return this.brandShortName = Cc["@mozilla.org/intl/stringbundle;1"]
alertHook.js:    let msgMailSession = Cc["@mozilla.org/messenger/services/session;1"]
autosync.js:    let bundleSvc = Cc["@mozilla.org/intl/stringbundle;1"]
glodaIndexer.js:    let bundleSvc = Cc["@mozilla.org/intl/stringbundle;1"]
moveCopy.js:    let bundleSvc = Cc["@mozilla.org/intl/stringbundle;1"]
moveCopy.js:    let acctMgr = Components.classes["@mozilla.org/messenger/account-manager;1"]
moveCopy.js:    let notificationService = Components.classes["@mozilla.org/messenger/msgnotificationservice;1"]
pop3Download.js:    let bundleSvc = Cc["@mozilla.org/intl/stringbundle;1"]
pop3Download.js:    pop3Service = Cc["@mozilla.org/messenger/popservice;1"]
sendLater.js:    let bundleSvc = Cc["@mozilla.org/intl/stringbundle;1"]
Comment 2 :aceman 2012-05-27 07:52:46 PDT
Created attachment 627565 [details] [diff] [review]
patch

Standard8, who could review this? It should be solely in the Activity manager.
Comment 3 Mark Banner (:standard8) 2012-05-31 08:09:06 PDT
Comment on attachment 627565 [details] [diff] [review]
patch

Oh, I forgot to say there's a little bit of bitrot in nsActivityManagerUI.js due to the license change.
Comment 4 :aceman 2012-05-31 11:37:21 PDT
Created attachment 628832 [details] [diff] [review]
patch v2

MPL2 bitrot.

Thanks for review.
Comment 5 Mike Conley (:mconley) - (needinfo me!) 2012-05-31 12:18:22 PDT
Landed in comm-central as https://hg.mozilla.org/comm-central/rev/828283ec0419

Note You need to log in before you can comment on or make changes to this bug.