758965 - Profiling branch shouldn't build pushes that are DONTBUILD on mozilla-central

Status: RESOLVED WONTFIX

(Release Engineering :: General, defect)

Description

[Ed Morley [:emorley]]

Since the profiling branch automated merge adds an additional changeset, it overrides the DONTBUILD if present in the mozilla-central push's tip changeset.

I suspect the best way to stop this is for Ehsan to adjust his script that does the merge, to add DONTBUILD in the merge changeset too when necessary.

Comment 1

[Ed Morley [:emorley]]

Ah thank you, I used FileIt and didn't check the product closely enough :-)

Comment 2

[Ed Morley [:emorley]]

Ehsan, is your script anywhere public, where I could tweak it? :-)

Comment 3

[(no longer active)]

(In reply to Ed Morley [:edmorley] from comment #2)
> Ehsan, is your script anywhere public, where I could tweak it? :-)

It is now!

https://github.com/ehsan/update-profiling

Comment 4

[Aki Sasaki (not active)]

Ed: should we assign this bug to you?

Comment 5

[Ed Morley [:emorley]]

Ok, so I started thinking about this more and have spoken to Ehsan/filed bug 763759.

Depending on how that pans out, this may end up just being WONTFIXED.

Comment 6

[Chris Cooper [:coop] (he/him)]

(In reply to Ed Morley [:edmorley] from comment #5) 
> Depending on how that pans out, this may end up just being WONTFIXED.

I think we're at that point now. Please re-open if I'm wrong.