Open
Bug 758995
Opened 13 years ago
Updated 3 years ago
nsIMsgDBHdr.isKilled is false for killed threads (but good /returns true for killed subthreads)
Categories
(MailNews Core :: Database, defect)
MailNews Core
Database
Tracking
(Not tracked)
ASSIGNED
People
(Reporter: squib, Assigned: squib)
Details
(Whiteboard: [patchlove][needs tests])
Attachments
(1 file)
1.08 KB,
patch
|
Bienvenu
:
feedback+
|
Details | Diff | Splinter Review |
It seems that nsIMsgDBHdr.isKilled only returns true for killed subthreads, not for killed threads. This is probably wrong, and we should fix it.
Assignee | ||
Comment 1•13 years ago
|
||
And here's a fix. Where's the best spot to test this?
Attachment #627599 -
Flags: feedback?(dbienvenu)
Comment 2•13 years ago
|
||
Comment on attachment 627599 [details] [diff] [review]
Fix this (no tests for now)
a msgdb xpcshell test would be the right place to add a test.
Attachment #627599 -
Flags: feedback?(dbienvenu) → feedback+
Comment 3•11 years ago
|
||
Jim, are you up for finishing?
Flags: needinfo?(squibblyflabbetydoo)
Summary: nsIMsgDBHdr.isKilled is false for killed threads → nsIMsgDBHdr.isKilled is false for killed threads (but good /returns true for killed subthreads)
Whiteboard: [patchlove][needs tests]
Assignee | ||
Comment 4•11 years ago
|
||
With some more-detailed pointers on how to test this, sure.
Flags: needinfo?(squibblyflabbetydoo)
Comment 5•11 years ago
|
||
(In reply to Jim Porter (:squib) from comment #4)
> With some more-detailed pointers on how to test this, sure.
Magnus, any thoughts? (ref comment 2)
Flags: needinfo?(mkmelin+mozilla)
Comment 6•11 years ago
|
||
Flags: needinfo?(mkmelin+mozilla)
Updated•3 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•