Closed
Bug 759047
Opened 13 years ago
Closed 13 years ago
backport connection-closing logic from AITC to sync1.1
Categories
(Cloud Services Graveyard :: Server: Sync, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: rfkelly, Unassigned)
Details
(Whiteboard: [qa+])
Attachments
(1 file)
|
16.66 KB,
patch
|
telliott
:
review+
|
Details | Diff | Splinter Review |
As part of the AITC loadtesting, we added some additional cleanup logic to the database handling code. This patch backports said logic to sync1.1. I'm hopeful this could help with Bug 682761, but even if not it seems like a good idea.
Attachment #627628 -
Flags: review?(telliott)
|
||
Updated•13 years ago
|
Whiteboard: [qa+]
|
||
Comment 1•13 years ago
|
||
Comment on attachment 627628 [details] [diff] [review]
sync1.1 patch for better cleanup of db connections
This is fine. I worry a little bit about fetchall, since it marshalls all the data into an object rather than taking a streaming approach. That can get pretty inefficient over large result sets. However, that's part of a much bigger discussion about streaming db results, so it's fine for here.
Attachment #627628 -
Flags: review?(telliott) → review+
|
Reporter | |
Comment 2•13 years ago
|
||
Yep, some day we need to see some more action on Bug 694221 for response streaming.
|
|
Reporter | |
Comment 3•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Updated•2 years ago
|
Product: Cloud Services → Cloud Services Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•