Closed Bug 759080 Opened 8 years ago Closed 8 years ago

Disable talos on the profiling branch

Categories

(Release Engineering :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: emorley, Assigned: emorley)

References

Details

Attachments

(1 file, 1 obsolete file)

Since the profiling branch does not have anything landed on it directly, I was wondering whether we could save some machine time by not running talos on it? (And maybe even turning off some of the other tests too)

Ehsan, would you be ok with that? If you wanted to make sure the browser at least started up ok, we could just one non-talos suite or something and leave everything else off? 

It's just that this bug + bug 758965 + the fact that many people still insist on using mozilla-central rather than inbound, means that profiling is using quite a bit of extra machine time, which is not helping things like http://oduinn.com/blog/2012/05/08/40207-test-jobs-in-a-24-hour-day/ :-)
We can turn off talos tests there.  We can't turn off the correctness tests since the profiling builds may actually be broken, as we might have code which depends on MOZ_PROFILING.
Summary: Consider disabling talos and maybe some other tests on the profiling branch → Disable talos on the profiling branch
And we should probably come up with ways of discouraging people to land on m-c for no good reason.  ;-)
(In reply to Ehsan Akhgari [:ehsan] from comment #2)
> And we should probably come up with ways of discouraging people to land on
> m-c for no good reason.  ;-)

Indeed, I've tried, but some will persist.
I almost think that a permanent approval required for mozilla-central (with a={bustage|merge|something-urgent-etc}) might be the way forwards.
Old habits die hard.  Maybe you can keep on pinging people asking "why did you push directly to m-c" until they get sick and tired of you asking them, and move to inbound?  :-)
"hi Ehsan told me to ask you why you are pushing to inbound...." ;-)
bah, s/inbound/mozilla-central/
(In reply to Ed Morley [:edmorley] from comment #5)
> "hi Ehsan told me to ask you why you are pushing to inbound...." ;-)

r=me with the nit in comment 6.  ;-)
Attached patch Patch v1 (obsolete) — Splinter Review
Assignee: nobody → bmo
Status: NEW → ASSIGNED
Attachment #629167 - Flags: review?(armenzg)
Comment on attachment 629167 [details] [diff] [review]
Patch v1

Changing it to False does the trick.
If you ever need to verify a change you can do this:
 cd repos/buildbot-configs/
 ./setup-master.py master bm04-tests1-macosx
 cd master
 buildbot start .
 # load localhost:8201
 # if you need to test another change
 buildbot reconfig .
 # load localhost:8201

There is also this set of instructions that would install dependencies in case buildbot and twisted were not installed on your machine:
https://wiki.mozilla.org/ReleaseEngineering/How_To/Setup_Personal_Development_Master
Attachment #629167 - Flags: review?(armenzg) → review-
Thanks for the patch!
Ah, I'd seen the (presumably redundant) |'enable_talos': True,| of build-system and thought the default was false (but judging by the others in the file, I guess it defaults to true).
Attached patch Patch v2Splinter Review
Attachment #629167 - Attachment is obsolete: true
Attachment #629177 - Flags: review?(armenzg)
Comment on attachment 629177 [details] [diff] [review]
Patch v2

Review of attachment 629177 [details] [diff] [review]:
-----------------------------------------------------------------

Sweet :)
Attachment #629177 - Flags: review?(armenzg) → review+
Would you like me to land this for you?
Thanks for the offer, thought I'd save you the hassle as I had it in my queue already :-)

http://hg.mozilla.org/build/buildbot-configs/rev/be2402a15734
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Thanks Ed!
We leave the bug open until the change gets merged to production.
At that moment we know that the masters have the change live and we can official it close it.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Ah yes, my bad. Habbit! :-)
Attachment #629177 - Flags: checked-in+
This went went into production today.
Status: REOPENED → RESOLVED
Closed: 8 years ago8 years ago
Resolution: --- → FIXED
Depends on: 799337
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.