759081 - Statistics bottom dates are not displayed properly for last 365 days

Status: VERIFIED FIXED

(Marketplace Graveyard :: Statistics, defect, P2)

Description

[Cristian Boldan]

Attachment: statistics bottom dates

Steps to reproduce:
1. Load Statistics for an app https://marketplace-dev.allizom.org/en-US/app/lord-of-ultima-1/statistics/?last=30
2. Group by "week".
3. Select for last "365 days".
4. Group by "day".

Expected results:
Bottom dates for the last 365 days are displayed properly.

Actual results:
Bottom dates are overlayed.

Notes/Issues:
Verified on FF15 Nightly (Win 7).
Attaching screenshot for this issue.

Comment 1

[Christopher Van Wiemeersch [:cvan]]

Kevin, want to take a look?

Comment 2

[Kevin Ngo [:ngoke]]

This has been fixed. Waiting on pull request.

Comment 3

[Christopher Van Wiemeersch [:cvan]]

This is what it looks like now when grouped by day:

    http://i.imgur.com/NzaTw.png

Grouped by week:

    http://i.imgur.com/HFPuS.png

I'm of the opinion that we should delay "group by day" and "group by week" when viewing the last 365 days. We should allow only "group by month":

    http://i.imgur.com/KQYky.png

Comment 4

[Kevin Ngo [:ngoke]]

I have a fix for this for group by day:

http://imgur.com/IKuaq.jpg

https://github.com/mozilla/zamboni/commit/d220b40e7506a7143b5bb8aca9531152e8a51937#L2R186

I forgot to address it for group by week.

Comment 5

[Cristian Boldan]

Issue is also reproducing on AMO for 365 days period when grouped by week 
https://addons-dev.allizom.org/en-US/firefox/addon/flashgot/statistics/?last=365
Attaching screenshot.

Comment 6

[Cristian Boldan]

Attachment: statistics bottom dates amo

Comment 7

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/zamboni/commit/92dde38

Comment 8

[Cristian Boldan]

Verified as fixed in https://marketplace-dev.allizom.org/en-US/app/lord-of-ultima-1/statistics/?last=365 and https://addons-dev.allizom.org/en-US/firefox/addon/firebug/statistics/?last=365 on FF15 and FF12 (Win 7)
Attaching postifx screencast.
Closing bug.

Comment 9

[Cristian Boldan]

Attachment: postfix statistics dates