759114 - Port bug 723176 - support mac dmg signing in the Thunderbird system

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect)

Description

[Mark Banner (:standard8)]

+++ This bug was initially created as a clone of Bug #723176 +++

We're picking up support for signing Mac builds ready for 10.8. We need to port the changes from that bug ready for the automation.

Comment 1

[Rail Aliiev [:rail]]

In bug 730328 I prepared a draft patch in attachment 626154 [details] [diff] [review]. Still needs to be updated, see bug 723176 for the details.

Comment 2

[Rail Aliiev [:rail]]

Attachment: enable mac signing

Refreshed patch, still need to be tested. buildbot-configs patch incoming.

Comment 3

[Rail Aliiev [:rail]]

Attachment: configs

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 627743 [details] [diff] [review]
enable mac signing

Ok, I'm not quite sure if we should be signing Contents/Library as well, I think we can get away with it at least initially as spotlight doesn't seem to be widely used with Thunderbird.

Given this should make it better for Thunderbird on 10.8 generally, lets get it out for some testing.

Comment 5

[Mark Banner (:standard8)]

Comment on attachment 627743 [details] [diff] [review]
enable mac signing

Checked in:

https://hg.mozilla.org/comm-central/rev/a36e027fc622

Comment 6

[Rail Aliiev [:rail]]

Comment on attachment 627745 [details] [diff] [review]
configs

http://hg.mozilla.org/build/buildbot-configs/rev/866f67bd7a5b

Comment 7

[[e-mail] (:bhearsum)]

(In reply to Mark Banner (:standard8) from comment #5)
> Comment on attachment 627743 [details] [diff] [review]
> enable mac signing
> 
> Checked in:
> 
> https://hg.mozilla.org/comm-central/rev/a36e027fc622

This may cause failures until the buildbot masters have been reconfiged w/ rail's patch.

Comment 8

[Mark Banner (:standard8)]

(In reply to Ben Hearsum [:bhearsum] from comment #7)
> (In reply to Mark Banner (:standard8) from comment #5)
> > Comment on attachment 627743 [details] [diff] [review]
> > enable mac signing
> > 
> > Checked in:
> > 
> > https://hg.mozilla.org/comm-central/rev/a36e027fc622
> 
> This may cause failures until the buildbot masters have been reconfiged w/
> rail's patch.

Yep, that's been done.

Comment 9

[Mark Banner (:standard8)]

Trunk nightlies were fine, so we've gone ahead and landed this on branches:

https://hg.mozilla.org/releases/comm-aurora/rev/fb929f78a916
https://hg.mozilla.org/releases/comm-beta/rev/82e2188d2a1a

Comment 10

[Mark Banner (:standard8)]

We may want this for esr, not sure yet.

Comment 12

[Mark Banner (:standard8)]

It was decided not to take this onto esr10 - esr17 will pick it up.