Closed Bug 759130 Opened 8 years ago Closed 8 years ago

Double accesskey in Sync preferences: Manage Account button and Add-ons

Categories

(Firefox :: Sync, defect)

defect
Not set
trivial

Tracking

()

RESOLVED FIXED
mozilla19

People

(Reporter: Tobbi, Assigned: ananuti)

Details

Attachments

(1 file)

In the Firefox Sync preferences in Tools > Options, you can find that the 'Manage account' button and the 'Add-ons' checkbox have the same accesskey, which is 'A' making it very difficult to access either of these options.
Good catch. This should be pretty simple to fix. Access keys are defined in browser/locales/en-US/chrome/browser/syncSetup.dtd
Whiteboard: [mentor=gps]
Comment on attachment 628184 [details] [diff] [review]
patch0 - change Manage Account button accesskey to n

Review of attachment 628184 [details] [diff] [review]:
-----------------------------------------------------------------

This looks fine. What about browser/locales/en-US/chrome/browser/syncSetup.dtd?

Also, some of these access keys are just weird. "m" for bookmarks. "r" for history. Can someone else weigh in with the historical background on why things are the way they are?
Attachment #628184 - Flags: feedback?(gps)
> This looks fine. What about browser/locales/en-US/chrome/browser/syncSetup.dtd?

You mean 'A' in 'Account' and 'Add-ons'?

> <!ENTITY signIn.account2.label      "Account">
> <!ENTITY signIn.account2.accesskey  "A">

> <!ENTITY engine.addons.label        "Add-ons">
> <!ENTITY engine.addons.accesskey    "A">

Those akeys are not shown at the same time. 'Account' is at Existing Account window, 'Add-ons' is at Sync Options window.
Are we going to land the patch?
> Also, some of these access keys are just weird. "m" for bookmarks. "r" for
> history. Can someone else weigh in with the historical background on why
> things are the way they are?

alt+h would open help page when the sync tab is selected in the options window so can't be used for history.  However, alt+b doesn't seem to do anything.
https://hg.mozilla.org/services/services-central/rev/b852b572cd64

Sorry it took so long. Thanks for the patch!
Status: NEW → ASSIGNED
Whiteboard: [mentor=gps] → [fixed in services]
https://hg.mozilla.org/mozilla-central/rev/b852b572cd64
Assignee: nobody → ananuti
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [fixed in services]
Target Milestone: --- → mozilla19
Component: Firefox Sync: UI → Sync
Product: Cloud Services → Firefox
You need to log in before you can comment on or make changes to this bug.