759130 - Double accesskey in Sync preferences: Manage Account button and Add-ons

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Tobias (:Tobbi) Markus]

In the Firefox Sync preferences in Tools > Options, you can find that the 'Manage account' button and the 'Add-ons' checkbox have the same accesskey, which is 'A' making it very difficult to access either of these options.

Comment 1

[Gregory Szorc [:gps]]

Good catch. This should be pretty simple to fix. Access keys are defined in browser/locales/en-US/chrome/browser/syncSetup.dtd

Comment 2

[Ekanan Ketunuti]

Attachment: patch0 - change Manage Account button accesskey to n

Comment 3

[Gregory Szorc [:gps]]

Comment on attachment 628184 [details] [diff] [review]
patch0 - change Manage Account button accesskey to n

Review of attachment 628184 [details] [diff] [review]:
-----------------------------------------------------------------

This looks fine. What about browser/locales/en-US/chrome/browser/syncSetup.dtd?

Also, some of these access keys are just weird. "m" for bookmarks. "r" for history. Can someone else weigh in with the historical background on why things are the way they are?

Comment 4

[Ekanan Ketunuti]

> This looks fine. What about browser/locales/en-US/chrome/browser/syncSetup.dtd?

You mean 'A' in 'Account' and 'Add-ons'?

> <!ENTITY signIn.account2.label      "Account">
> <!ENTITY signIn.account2.accesskey  "A">

> <!ENTITY engine.addons.label        "Add-ons">
> <!ENTITY engine.addons.accesskey    "A">

Those akeys are not shown at the same time. 'Account' is at Existing Account window, 'Add-ons' is at Sync Options window.

Comment 5

[Raymond Lee [:raymondlee]]

Are we going to land the patch?

Comment 6

[Raymond Lee [:raymondlee]]

> Also, some of these access keys are just weird. "m" for bookmarks. "r" for
> history. Can someone else weigh in with the historical background on why
> things are the way they are?

alt+h would open help page when the sync tab is selected in the options window so can't be used for history.  However, alt+b doesn't seem to do anything.

Comment 7

[Gregory Szorc [:gps]]

https://hg.mozilla.org/services/services-central/rev/b852b572cd64

Sorry it took so long. Thanks for the patch!

Comment 8

[Richard Newman [:rnewman]]

https://hg.mozilla.org/mozilla-central/rev/b852b572cd64