turn focus logging macros into standard a11y logging

RESOLVED FIXED in mozilla18

Status

()

Core
Disability Access APIs
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: surkov, Assigned: surkov)

Tracking

unspecified
mozilla18
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug][mentor=surkov.alexander@gmail.com][lang=c++])

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
similar to bug 746084, see A11YDEBUG_FOCUS macros in base/FocusManager.h
Is anyone working on this bug? If not, I am interested in working, though it's my first time in #accessibility so I might need some help :-|
(In reply to Atul Jangra from comment #1)
> Is anyone working on this bug? If not, I am interested in working, though
> it's my first time in #accessibility so I might need some help :-|

nobody is the assigny so no, no one is working on it.
(Assignee)

Updated

6 years ago
Assignee: nobody → atuljangra66
(Assignee)

Comment 3

6 years ago
(In reply to Atul Jangra [:atuljangra] from comment #1)
> Is anyone working on this bug? If not, I am interested in working, though
> it's my first time in #accessibility so I might need some help :-|

Are you still active on this bug?
I am not active. I have few other bigs on my priority list. If someone else is willing to take this, then that's perfect, otherwise I'll be happy to work on this one, but that might take some time. :-)
(Assignee)

Comment 5

6 years ago
(In reply to Atul Jangra [:atuljangra] from comment #4)
> I am not active. I have few other bigs on my priority list. If someone else
> is willing to take this, then that's perfect, otherwise I'll be happy to
> work on this one, but that might take some time. :-)

Ok, I'll steal this one since we need it for intermittent test failures analysis. When you finish those two please take a look at other bugs: we have lot of stuffs to do.
(Assignee)

Comment 6

6 years ago
Created attachment 664456 [details] [diff] [review]
patch
Assignee: atuljangra66 → surkov.alexander
Status: NEW → ASSIGNED
Attachment #664456 - Flags: review?(trev.saunders)
(Assignee)

Updated

6 years ago
Blocks: 708927
Comment on attachment 664456 [details] [diff] [review]
patch

>@@ -491,26 +558,44 @@ logging::MsgBegin(const char* aTitle, co
> {
>   printf("\nA11Y %s: ", aTitle);
> 
>   va_list argptr;
>   va_start(argptr, aMsgText);
>   vprintf(aMsgText, argptr);
>   va_end(argptr);
> 
>+  PRIntervalTime time = PR_IntervalNow();
>+  uint32_t mins = (PR_IntervalToSeconds(time) / 60) % 60;
>+  uint32_t secs = PR_IntervalToSeconds(time) % 60;
>+  uint32_t msecs = PR_IntervalToMilliseconds(time) % 1000;
>+  printf("; %02d:%02d.%03d", mins, secs, msecs);

nit, it'd be nice if you changed that to mozilla::TimeStamp / Duration
Attachment #664456 - Flags: review?(trev.saunders) → review+
(Assignee)

Comment 8

6 years ago
(In reply to Trevor Saunders (:tbsaunde) from comment #7)

> nit, it'd be nice if you changed that to mozilla::TimeStamp / Duration

per irc: we agreed to not do that since these classes look designed for different purpose.
(Assignee)

Comment 9

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/ccdb0107dd61
Target Milestone: --- → mozilla18
https://hg.mozilla.org/mozilla-central/rev/ccdb0107dd61
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Bug is fixed :-) AWESOME work!!
You need to log in before you can comment on or make changes to this bug.