759133 - turn focus logging macros into standard a11y logging

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[alexander :surkov (:asurkov)]

similar to bug 746084, see A11YDEBUG_FOCUS macros in base/FocusManager.h

Comment 1

[Atul Jangra [:atuljangra]]

Is anyone working on this bug? If not, I am interested in working, though it's my first time in #accessibility so I might need some help :-|

Comment 2

[Trevor Saunders (:tbsaunde)]

(In reply to Atul Jangra from comment #1)
> Is anyone working on this bug? If not, I am interested in working, though
> it's my first time in #accessibility so I might need some help :-|

nobody is the assigny so no, no one is working on it.

Comment 3

[alexander :surkov (:asurkov)]

(In reply to Atul Jangra [:atuljangra] from comment #1)
> Is anyone working on this bug? If not, I am interested in working, though
> it's my first time in #accessibility so I might need some help :-|

Are you still active on this bug?

Comment 4

[Atul Jangra [:atuljangra]]

I am not active. I have few other bigs on my priority list. If someone else is willing to take this, then that's perfect, otherwise I'll be happy to work on this one, but that might take some time. :-)

Comment 5

[alexander :surkov (:asurkov)]

(In reply to Atul Jangra [:atuljangra] from comment #4)
> I am not active. I have few other bigs on my priority list. If someone else
> is willing to take this, then that's perfect, otherwise I'll be happy to
> work on this one, but that might take some time. :-)

Ok, I'll steal this one since we need it for intermittent test failures analysis. When you finish those two please take a look at other bugs: we have lot of stuffs to do.

Comment 6

[alexander :surkov (:asurkov)]

Attachment: patch

Comment 7

[Trevor Saunders (:tbsaunde)]

Comment on attachment 664456 [details] [diff] [review]
patch

>@@ -491,26 +558,44 @@ logging::MsgBegin(const char* aTitle, co
> {
>   printf("\nA11Y %s: ", aTitle);
> 
>   va_list argptr;
>   va_start(argptr, aMsgText);
>   vprintf(aMsgText, argptr);
>   va_end(argptr);
> 
>+  PRIntervalTime time = PR_IntervalNow();
>+  uint32_t mins = (PR_IntervalToSeconds(time) / 60) % 60;
>+  uint32_t secs = PR_IntervalToSeconds(time) % 60;
>+  uint32_t msecs = PR_IntervalToMilliseconds(time) % 1000;
>+  printf("; %02d:%02d.%03d", mins, secs, msecs);

nit, it'd be nice if you changed that to mozilla::TimeStamp / Duration

Comment 8

[alexander :surkov (:asurkov)]

(In reply to Trevor Saunders (:tbsaunde) from comment #7)

> nit, it'd be nice if you changed that to mozilla::TimeStamp / Duration

per irc: we agreed to not do that since these classes look designed for different purpose.

Comment 9

[alexander :surkov (:asurkov)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/ccdb0107dd61

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/ccdb0107dd61

Comment 11

[Atul Jangra [:atuljangra]]

Bug is fixed :-) AWESOME work!!