759158 - Add accessibility status to about:support

Status: VERIFIED FIXED

(Core :: Disability Access APIs, defect)

Description

[David Bolter [:davidb] (NeedInfo me for attention)]

For all platforms. I propose a section in about:support called "Accessibility". First item could be "activated" or "instantiated".

Comment 1

[Hubert Figuiere [:hub]]

Also a status like "disabled" for when we build without.

Comment 2

[David Bolter [:davidb] (NeedInfo me for attention)]

Attachment: WIP (works)

Comment 3

[Hubert Figuiere [:hub]]

Comment on attachment 632391 [details] [diff] [review]
WIP (works)

Review of attachment 632391 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/content/aboutSupport.js
@@ +409,5 @@
> +  try {
> +    enabled = Components.manager.QueryInterface(Ci.nsIServiceManager)
> +      .isServiceInstantiatedByContractID(
> +        "@mozilla.org/accessibilityService;1",
> +        Ci.nsISupports);

See bug 761589: we should also have these, IMHO

Comment 4

[David Bolter [:davidb] (NeedInfo me for attention)]

Sounds good.

Comment 5

[David Bolter [:davidb] (NeedInfo me for attention)]

Actually hub, how about I go ahead and get this reviewed and landed, and you can do the additional support info in a follow up after 761589 is finished?

Comment 6

[Hubert Figuiere [:hub]]

(In reply to David Bolter [:davidb] from comment #5)
> Actually hub, how about I go ahead and get this reviewed and landed, and you
> can do the additional support info in a follow up after 761589 is finished?

yeah sure.

Comment 7

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 632391 [details] [diff] [review]
WIP (works)

Review of attachment 632391 [details] [diff] [review]:
-----------------------------------------------------------------

Adds accessibility activated yes/no info to about:support.

Comment 8

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 632391 [details] [diff] [review]
WIP (works)

I assume you've tested that this works (both disabled/enabled show up correctly as appropriate).

Rather than using "yes"/"no", you should use 1/0 like the Incremental GC string, so that this doesn't stick out too much in localized builds.

Comment 9

[David Bolter [:davidb] (NeedInfo me for attention)]

(In reply to :Gavin Sharp (use [e-mail] for email) from comment #8)
> Comment on attachment 632391 [details] [diff] [review]
> WIP (works)
> 
> I assume you've tested that this works (both disabled/enabled show up
> correctly as appropriate).

Yes.

> Rather than using "yes"/"no", you should use 1/0 like the Incremental GC
> string, so that this doesn't stick out too much in localized builds.

Good catch. Will land with 1/0

Comment 10

[David Bolter [:davidb] (NeedInfo me for attention)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7ef9568fbd40

Comment 11

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/7ef9568fbd40

Comment 12

[Marco Zehe (:MarcoZ)]

Verified in Mozilla/5.0 (Windows NT 6.1; WOW64; rv:16.0) Gecko/16.0 Firefox/16.0. This shows up in about:support.