The default bug view has changed. See this FAQ.

Add accessibility status to about:support

VERIFIED FIXED in mozilla16

Status

()

Core
Disability Access APIs
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: davidb, Assigned: davidb)

Tracking

unspecified
mozilla16
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
For all platforms. I propose a section in about:support called "Accessibility". First item could be "activated" or "instantiated".
Also a status like "disabled" for when we build without.
(Assignee)

Comment 2

5 years ago
Created attachment 632391 [details] [diff] [review]
WIP (works)
Assignee: nobody → dbolter
Comment on attachment 632391 [details] [diff] [review]
WIP (works)

Review of attachment 632391 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/content/aboutSupport.js
@@ +409,5 @@
> +  try {
> +    enabled = Components.manager.QueryInterface(Ci.nsIServiceManager)
> +      .isServiceInstantiatedByContractID(
> +        "@mozilla.org/accessibilityService;1",
> +        Ci.nsISupports);

See bug 761589: we should also have these, IMHO
(Assignee)

Comment 4

5 years ago
Sounds good.
(Assignee)

Comment 5

5 years ago
Actually hub, how about I go ahead and get this reviewed and landed, and you can do the additional support info in a follow up after 761589 is finished?
(In reply to David Bolter [:davidb] from comment #5)
> Actually hub, how about I go ahead and get this reviewed and landed, and you
> can do the additional support info in a follow up after 761589 is finished?

yeah sure.
(Assignee)

Comment 7

5 years ago
Comment on attachment 632391 [details] [diff] [review]
WIP (works)

Review of attachment 632391 [details] [diff] [review]:
-----------------------------------------------------------------

Adds accessibility activated yes/no info to about:support.
Attachment #632391 - Flags: review?(gavin.sharp)
Comment on attachment 632391 [details] [diff] [review]
WIP (works)

I assume you've tested that this works (both disabled/enabled show up correctly as appropriate).

Rather than using "yes"/"no", you should use 1/0 like the Incremental GC string, so that this doesn't stick out too much in localized builds.
Attachment #632391 - Flags: review?(gavin.sharp) → review+
(Assignee)

Comment 9

5 years ago
(In reply to :Gavin Sharp (use gavin@gavinsharp.com for email) from comment #8)
> Comment on attachment 632391 [details] [diff] [review]
> WIP (works)
> 
> I assume you've tested that this works (both disabled/enabled show up
> correctly as appropriate).

Yes.

> Rather than using "yes"/"no", you should use 1/0 like the Incremental GC
> string, so that this doesn't stick out too much in localized builds.

Good catch. Will land with 1/0
(Assignee)

Comment 10

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/7ef9568fbd40
Target Milestone: --- → mozilla16
https://hg.mozilla.org/mozilla-central/rev/7ef9568fbd40
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Updated

5 years ago
Blocks: 769304
Verified in Mozilla/5.0 (Windows NT 6.1; WOW64; rv:16.0) Gecko/16.0 Firefox/16.0. This shows up in about:support.
Status: RESOLVED → VERIFIED
(Assignee)

Updated

5 years ago
Blocks: 769302
You need to log in before you can comment on or make changes to this bug.