If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Display dot in window close widget of windows with unsaved contents

NEW
Unassigned

Status

()

Core
XUL
--
enhancement
17 years ago
2 months ago

People

(Reporter: hsivonen, Unassigned)

Tracking

(Blocks: 2 bugs)

Trunk
x86
Mac OS X
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(2 attachments)

(Reporter)

Description

17 years ago
On Mac OS X, the window close button is supposed to have a dot in the middle, if
the window contains unsaved changes. Editor windows don't support this.

See page 55 of the Aqua HIG (Macworld draft).
(Reporter)

Comment 1

17 years ago
Created attachment 30781 [details]
Actual results
(Reporter)

Comment 2

17 years ago
Created attachment 30782 [details]
Expected results (when there are unsaved changes)

Comment 3

17 years ago
We need to use the SetWindowModified API, or whatever it's called, and should 
probably have generic hooks for this. nsIDiskDocument would be a good place at 
the lower level, but this would need to communicate up to the widget layer 
somehow. This is kinda similar to the window icon problem.
(Reporter)

Updated

17 years ago
Blocks: 73812

Updated

17 years ago
Target Milestone: --- → mozilla1.0

Comment 4

17 years ago
I was looking at this for some of the window icon stuff and editor at least has
an api where you can attach listeners to the ?document? who can observe whether
its dirty or not. However since presumably mail compose windows want to do this
too, it should be done at a lower level than editor.

Henri, did you intend this bug to apply to more than the editor? ie, will you
make another one for mailnews?

Comment 5

17 years ago
Why wouldn't mail compose windows also want this behavior?  Wouldn't users want 
to know if the draft had been saved or not?  I think this bug should cover both 
Composer and Mail Compose.
(Reporter)

Comment 6

17 years ago
I haven't been testing Mail&News, but this probably applies to more than just
the Editor.
Summary: Dot indicating unsaved changes not supported in Editor windows → Dot indicating unsaved changes not supported

Updated

17 years ago
Priority: -- → P4

Updated

17 years ago
Whiteboard: OSX

Updated

16 years ago
Blocks: 90824

Comment 7

16 years ago
Bugs targeted at mozilla1.0 without the mozilla1.0 keyword moved to mozilla1.0.1 
(you can query for this string to delete spam or retrieve the list of bugs I've 
moved)
Target Milestone: mozilla1.0 → mozilla1.0.1

Updated

16 years ago
Whiteboard: OSX

Comment 8

16 years ago
Pre-sabbatical bug triage.
Target Milestone: mozilla1.0.1 → mozilla1.2alpha

Comment 9

15 years ago
Revising summary.
Summary: Dot indicating unsaved changes not supported → Display dot in window close widget of windows with unsaved contents

Updated

15 years ago
Target Milestone: mozilla1.2alpha → mozilla1.5alpha

Comment 10

12 years ago
*** Bug 317813 has been marked as a duplicate of this bug. ***
see also bug 370318
QA Contact: sujay → editor
Duplicate of this bug: 374502

Updated

9 years ago
Assignee: sfraser_bugs → nobody
Now works in BlueGriffon ; see

http://sources.disruptive-innovations.com/bluegriffon/trunk/src/diOSXDockIconBadger/

and |<method name="updateOSXCloseButton">| in
http://sources.disruptive-innovations.com/bluegriffon/trunk/base/content/bluegriffon/bindings/tabeditor.xml
Assignee: nobody → daniel
Component: Editor → OS Integration
Priority: P4 → --
Product: Core → Composer
QA Contact: editor
Target Milestone: mozilla1.5alpha → ---
Version: Trunk → other
Severity: normal → enhancement
Hardware: PowerPC → x86
ehsan just made me the owner of this bug... Hey, ehsan, ask me next time ?
Ok, I'll try to make a patch for composer here.
(In reply to comment #14)
> ehsan just made me the owner of this bug... Hey, ehsan, ask me next time ?

I didn't actually!  You just seem to be the default assignee for this component (probably dating back to several years ago)!  Please file a bug to get that fixed.  :-)

Sorry for the confusion.  ;-)
Assignee: daniel → nobody
(In reply to comment #15)
> (In reply to comment #14)
> > ehsan just made me the owner of this bug... Hey, ehsan, ask me next time ?
> I didn't actually!  You just seem to be the default assignee for this component
I don't think composer is the right component for this anyway, it seems like something that should be fixed using either an attribute on the <window> or a property on nsIChromeWindow or maybe nsIXULWindow.

At some point web pages (e.g. webmail) might want to be able to notify the chrome as to whether they have unsaved changes too, and chrome could then set the dot if any of the tabs has unsaved changes.
OK, moving over to XUL then.
Component: OS Integration → XUL
Product: Composer → Core
QA Contact: xptoolkit.widgets
Version: other → Trunk
See Also: → bug 601550
You need to log in before you can comment on or make changes to this bug.