Closed Bug 759385 Opened 12 years ago Closed 12 years ago

GonkSwitch.cpp should silently ignore non-switch events

Categories

(Firefox OS Graveyard :: General, defect)

Product:
Firefox OS Graveyard
Component:
General
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED DUPLICATE of bug 758097

People

(Reporter: dhylands, Unassigned)

Details

Attachments

(1 file)

Fix GonkSwitch to not report non-switch events as failures
837 bytes, patch
qdot
: review+
Details | Diff | Splinter Review 
GonkSwitch.cpp currently does a NS_ENSURE_TRUE(rv, SWITCH_DEVICE_UNKNOWN) inside it's ProcessEvent function.

This causes every non-switch netlink event to be reported like:
WARNING: NS_ENSURE_TRUE(rv) failed: file /home/work/B2G/gecko/hal/gonk/GonkSwitch.cpp, line 135

It should just silently ignore non-switch events since they are expected.
Attachment #628008 - Flags: review?(kyle)
Attachment #628008 - Flags: review?(kyle) → review+
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: