759415 - Initial code review for SocialAPI

Status: RESOLVED INVALID

(Firefox Graveyard :: SocialAPI, defect)

Description

[Shane Caraveo (:mixedpuppy)]

getting a preliminary code review done would be great.

Comment 1

[Shane Caraveo (:mixedpuppy)]

Attachment: core socialapi modules

Comment 2

[Shane Caraveo (:mixedpuppy)]

We have a branch with the core modules and tests at 

http://hg.mozilla.org/users/mhammond_skippinet.com.au/mc-socialapi-core

You can find the sources under browser/extensions/socialapi

As well, the patch is attached to this bug.  Only the makefile in browser/extensions is actually patched, the rest are new files, so may be easier to review out of the repository.

This patch does not include any UI, just the core frameworker and manifest repository related modules.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 628814 [details] [diff] [review]
core socialapi modules

So just at a high level, I see a few things in this patch:
- some testing code (excellent!)
- extension packaging goop
- default prefs utility code
- typedStorage.jsm utility code (uses sync storage API :( )
- frameworker module
- manifest utility code: manifestDB.jsm and manifest.jsm (includes installation prompting code, not yet localized)
- provider registry (registry.js)

Those all seem like pieces that should be split out into their own bugs.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

We've split this out into several bugs - bug 762569, bug 762579, etc.