759473 - X-Axis values remain unaffected by 'Group by' selection

Status: VERIFIED FIXED

(Marketplace Graveyard :: Statistics, defect)

Description

[krupa raj[:krupa]]

Attachment: screenshot

steps to reproduce:
1. Load https://marketplace-dev.allizom.org/en-US/app/evernote-web/statistics/?last=30
2. Select 'Group by' option to be "day"

expected behavior:
With 'Group by' set to "day" X-Axis value is in days.

actual behavior:
With 'Group by' set to "day" X-Axis value is in weeks. See screenshot

Comment 1

[Kevin Ngo [:ngoke]]

This has been fixed, waiting on a pull request.

Comment 2

[Christopher Van Wiemeersch [:cvan]]

(In reply to Kevin Ngo [:ngoke] from comment #1)
> This has been fixed, waiting on a pull request.

This is different than bug 759099 - if that's the bug you're referring to.

Comment 3

[Kevin Ngo [:ngoke]]

https://github.com/mozilla/zamboni/commit/7c3d9685ac8e4536e35b800c70b18ff7bff420b4

Comment 5

[Christopher Van Wiemeersch [:cvan]]

Not a dupe - however, this has been fixed, but not from the commit (7c3d9685) above.

Comment 6

[Victor Carciu]

Working fine when grouped by day, but not working as expected when grouped by weeks(X-axis should display weeks not days).

Please see attached screenshot.

Comment 7

[Victor Carciu]

Attachment: X Axis view when grouped by week.

Comment 8

[Kevin Ngo [:ngoke]]

https://github.com/mozilla/zamboni/commit/acbf3787517842f97558778814e23eec5ed2d902

Comment 9

[Victor Carciu]

Verified as fixed

Comment 10

[Victor Carciu]

Attachment: Postfix Screenshot