The default bug view has changed. See this FAQ.

Large amount of heap churn seemingly coming from InferSpewColorable (Debug-only)

RESOLVED FIXED in mozilla15

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: bas, Assigned: jandem)

Tracking

unspecified
mozilla15
x86_64
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
I was doing some memory profiling from another bug I'm looking at and I noticed the profiler telling me that there's an incredible amount of heap churn coming an allocation in InferSpewColorable (jsinfer.cpp:141). I should note this is in a debug build! I realize the code here is debug only.

In my (very low use) session that has only 3 tabs open for under 10 minutes with relatively little activity. this was responsible for over 60% of the blocks allocated(and freed) on the heap, at a grand total of 12 million blocks. Even for debug purposes that seems like it might be a little excessive.
(Assignee)

Comment 1

5 years ago
Created attachment 628268 [details] [diff] [review]
Patch

This bug reminded me of another problem with the spew colors: since OS X 10.7 the TERM variable is xterm-256color instead of xterm-color so the colors stopped working.

The patch uses a static variable to avoid multiple lookups and adds xterm-256color.
Assignee: general → jdemooij
Status: NEW → ASSIGNED
Attachment #628268 - Flags: review?(bhackett1024)
Attachment #628268 - Flags: review?(bhackett1024) → review+
(Assignee)

Comment 2

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/b072bbec8bda
Target Milestone: --- → mozilla15
https://hg.mozilla.org/mozilla-central/rev/b072bbec8bda
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.