Closed
Bug 759645
Opened 12 years ago
Closed 12 years ago
enable extended logging for a11y tree and text changes
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla15
People
(Reporter: surkov, Assigned: surkov)
Details
Attachments
(1 file)
16.96 KB,
patch
|
tbsaunde
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #628217 -
Flags: review?(trev.saunders)
Comment 1•12 years ago
|
||
Comment on attachment 628217 [details] [diff] [review] patch >+ va_start(argptr, aEntryText); >+ vfprintf(stdout, aEntryText, argptr); nit, what's wrong with vprintf()? >@@ -76,26 +80,36 @@ void OuterDocDestroy(OuterDocAccessible* > * Log the message ('title: text' format) on new line. Print the start and end > * boundaries of the message body designed by '{' and '}' (2 spaces indent for > * body). > */ > void MsgBegin(const char* aTitle, const char* aMsgText, ...); > void MsgEnd(); > > /** >+ * Log the entry into message body (4 spaces offset). this comment and the previous one are inconsistant. > // Uncomment to log notifications processing. > //#define DEBUG_NOTIFICATIONS still needed for something? >+ logging::Node("container", aContainer); >+ for (nsIContent* child = aStartChild; child != aEndChild; >+ child = child->GetNextSibling()) { >+ logging::Node("content", child); >+ } >+ logging::MsgEnd(); nit, blank line after }?
Attachment #628217 -
Flags: review?(trev.saunders) → review+
Assignee | ||
Comment 2•12 years ago
|
||
(In reply to Trevor Saunders (:tbsaunde) from comment #1) > >+ va_start(argptr, aEntryText); > >+ vfprintf(stdout, aEntryText, argptr); > > nit, what's wrong with vprintf()? nothing, I just was used the first thing I found > >@@ -76,26 +80,36 @@ void OuterDocDestroy(OuterDocAccessible* > > * Log the message ('title: text' format) on new line. Print the start and end > > * boundaries of the message body designed by '{' and '}' (2 spaces indent for > > * body). > > /** > >+ * Log the entry into message body (4 spaces offset). > > this comment and the previous one are inconsistant. they are, body designated by { } is 2 spaces, entry inside body is 4 spaces > > // Uncomment to log notifications processing. > > //#define DEBUG_NOTIFICATIONS > > still needed for something? yes, there's a review request in your queue > >+ logging::Node("container", aContainer); > >+ for (nsIContent* child = aStartChild; child != aEndChild; > >+ child = child->GetNextSibling()) { > >+ logging::Node("content", child); > >+ } > >+ logging::MsgEnd(); > > nit, blank line after }? no, just keeping the whole message without empty lines. it looks ok :)
Comment 3•12 years ago
|
||
> > >@@ -76,26 +80,36 @@ void OuterDocDestroy(OuterDocAccessible*
> > > * Log the message ('title: text' format) on new line. Print the start and end
> > > * boundaries of the message body designed by '{' and '}' (2 spaces indent for
> > > * body).
>
> > > /**
> > >+ * Log the entry into message body (4 spaces offset).
> >
> > this comment and the previous one are inconsistant.
>
> they are, body designated by { } is 2 spaces, entry inside body is 4 spaces
ok, that didn't make sense to me from the comments
Assignee | ||
Comment 4•12 years ago
|
||
(In reply to Trevor Saunders (:tbsaunde) from comment #3) > > they are, body designated by { } is 2 spaces, entry inside body is 4 spaces > > ok, that didn't make sense to me from the comments I see. perhaps not big deal (not sure how to make them clear enough)
Comment 5•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f7bb3ca58969
Target Milestone: --- → mozilla15
Assignee | ||
Updated•12 years ago
|
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•