Intermittent browser_privatebrowsing_ui.js | leaked until shutdown [nsGlobalWindow #2329 about:blank]

RESOLVED WORKSFORME

Status

()

Firefox
Private Browsing
RESOLVED WORKSFORME
6 years ago
5 years ago

People

(Reporter: emorley, Unassigned)

Tracking

({intermittent-failure, memory-leak})

Trunk
x86
Windows XP
intermittent-failure, memory-leak
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox15 affected, firefox16 affected, firefox17 affected)

Details

(Reporter)

Description

6 years ago
https://tbpl.mozilla.org/php/getParsedLog.php?id=12191830&tree=Mozilla-Inbound

[browser/components/privatebrowsing/test/browser/browser_privatebrowsing_ui.js]
  1 window(s) [url = about:blank]
  1 window(s) [url = chrome://browser/content/browser.xul]
(Reporter)

Updated

6 years ago
Blocks: 438871
Whiteboard: [orange]
(Reporter)

Comment 1

6 years ago
https://tbpl.mozilla.org/php/getParsedLog.php?id=12197557&tree=Firefox

[browser/components/privatebrowsing/test/browser/browser_privatebrowsing_ui.js]
  2 window(s) [url = chrome://browser/content/browser.xul]
  2 window(s) [url = about:blank]
(Reporter)

Comment 2

6 years ago
https://tbpl.mozilla.org/php/getParsedLog.php?id=12197953&tree=Mozilla-Inbound

[browser/components/privatebrowsing/test/browser/browser_privatebrowsing_ui.js]
  1 window(s) [url = chrome://browser/content/browser.xul]
  1 window(s) [url = about:blank]
(Reporter)

Comment 3

6 years ago
https://tbpl.mozilla.org/php/getParsedLog.php?id=12200926&tree=Firefox

[browser/components/privatebrowsing/test/browser/browser_privatebrowsing_ui.js]
  1 window(s) [url = about:blank]
  1 window(s) [url = chrome://browser/content/browser.xul]
(Reporter)

Comment 4

6 years ago
https://tbpl.mozilla.org/php/getParsedLog.php?id=12214747&tree=Mozilla-Inbound

[browser/components/privatebrowsing/test/browser/browser_privatebrowsing_ui.js]
  3 window(s) [url = chrome://browser/content/browser.xul]
  3 window(s) [url = about:blank]
(Reporter)

Comment 5

6 years ago
https://tbpl.mozilla.org/php/getParsedLog.php?id=12237542&tree=Firefox

[browser/components/privatebrowsing/test/browser/browser_privatebrowsing_ui.js]
  2 window(s) [url = chrome://browser/content/browser.xul]
  2 window(s) [url = about:blank]
(Reporter)

Comment 6

6 years ago
https://tbpl.mozilla.org/php/getParsedLog.php?id=12256032&tree=Firefox

[browser/components/privatebrowsing/test/browser/browser_privatebrowsing_ui.js]
  1 window(s) [url = about:blank]
  1 window(s) [url = chrome://browser/content/browser.xul]
(Reporter)

Comment 7

6 years ago
https://tbpl.mozilla.org/php/getParsedLog.php?id=12409135&tree=Mozilla-Inbound

[browser/components/privatebrowsing/test/browser/browser_privatebrowsing_ui.js]
  2 window(s) [url = about:blank]
  2 window(s) [url = chrome://browser/content/browser.xul]
(Reporter)

Comment 8

6 years ago
https://tbpl.mozilla.org/php/getParsedLog.php?id=12448575&tree=Mozilla-Inbound

[browser/components/privatebrowsing/test/browser/browser_privatebrowsing_ui.js]
  1 window(s) [url = chrome://browser/content/browser.xul]
  1 window(s) [url = about:blank]
(Reporter)

Comment 9

6 years ago
https://tbpl.mozilla.org/php/getParsedLog.php?id=12427880&tree=Mozilla-Inbound

[browser/components/privatebrowsing/test/browser/browser_privatebrowsing_ui.js]
  1 window(s) [url = chrome://browser/content/browser.xul]
  1 window(s) [url = about:blank]
(Reporter)

Comment 10

6 years ago
https://tbpl.mozilla.org/php/getParsedLog.php?id=12481264&tree=Mozilla-Inbound

[browser/components/privatebrowsing/test/browser/browser_privatebrowsing_ui.js]
  1 window(s) [url = chrome://browser/content/browser.xul]
  1 window(s) [url = about:blank]
(Reporter)

Comment 11

6 years ago
https://tbpl.mozilla.org/php/getParsedLog.php?id=12483557&tree=Mozilla-Inbound#error0

[browser/components/privatebrowsing/test/browser/browser_privatebrowsing_ui.js]
  2 window(s) [url = chrome://browser/content/browser.xul]
  2 window(s) [url = about:blank]
(Reporter)

Comment 12

6 years ago
https://tbpl.mozilla.org/php/getParsedLog.php?id=12570406&tree=Mozilla-Aurora

[browser/components/privatebrowsing/test/browser/browser_privatebrowsing_ui.js]
  1 window(s) [url = about:blank]
  1 window(s) [url = chrome://browser/content/browser.xul]
(Reporter)

Comment 13

6 years ago
https://tbpl.mozilla.org/php/getParsedLog.php?id=12762145&tree=Mozilla-Inbound

[browser/components/privatebrowsing/test/browser/browser_privatebrowsing_ui.js]
  1 window(s) [url = chrome://browser/content/browser.xul]
  1 window(s) [url = about:blank]
(Reporter)

Comment 14

6 years ago
https://tbpl.mozilla.org/php/getParsedLog.php?id=12803052&tree=Fx-Team

[browser/components/privatebrowsing/test/browser/browser_privatebrowsing_ui.js]
  1 window(s) [url = about:blank]
  1 window(s) [url = chrome://browser/content/browser.xul]
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
(Reporter)

Updated

6 years ago
status-firefox15: --- → affected
status-firefox16: --- → affected
status-firefox17: --- → affected
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
(Reporter)

Comment 193

6 years ago
Hasn't shown up on trunk after bug 728294 landed, so going to call this a false positive and mark WFM for now.
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → WORKSFORME
Comment hidden (Treeherder Robot)
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
(Reporter)

Updated

6 years ago
Summary: Intermittent leak in browser_privatebrowsing_ui.js → Intermittent browser_privatebrowsing_ui.js | leaked until shutdown [nsGlobalWindow #2329 about:blank]
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
(Assignee)

Updated

6 years ago
Keywords: intermittent-failure
(Assignee)

Updated

6 years ago
Whiteboard: [orange]
I found a pretty simple way to reproduce this consistently. If anyone wants to work on it, please ping me.
(Reporter)

Comment 202

6 years ago
(In reply to Bill McCloskey (:billm) from comment #201)
> I found a pretty simple way to reproduce this consistently. If anyone wants
> to work on it, please ping me.

Ehsan, please may you take a look / assign to someone who can? 
Thank you :-)
Flags: needinfo?(ehsan)

Comment 203

6 years ago
This test will soon be removed.. But I'm curious, Bill.  How do you reliably reproduce this?
Flags: needinfo?(ehsan)
(In reply to Ehsan Akhgari [:ehsan] from comment #203)
> This test will soon be removed.. But I'm curious, Bill.  How do you reliably
> reproduce this?

There are certain circumstances where, before doing a CC, we run a full GC. This is normally very rare, but I was doing some testing where I made it always happen that way. That causes this test to leak reliably.

Comment 205

6 years ago
(In reply to comment #204)
> (In reply to Ehsan Akhgari [:ehsan] from comment #203)
> > This test will soon be removed.. But I'm curious, Bill.  How do you reliably
> > reproduce this?
> 
> There are certain circumstances where, before doing a CC, we run a full GC.
> This is normally very rare, but I was doing some testing where I made it always
> happen that way. That causes this test to leak reliably.

Hmm, that's weird.  Can you please elaborate more?  I'm not sure what this test could be doing to cause that to happen (unless it's uncovering a deeper issue somehow.)
What Bill is saying is that when we trigger a full GC right before a CC (without doing anything in between), then there is a leak.

Normally, this happens only rarely, which would be why it would be an intermittent orange, but Bill had a patch that made this rare circumstance instead always happen.

Comment 207

6 years ago
I see.  CCing smaug.  Who else should know about this?
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
(Reporter)

Comment 213

5 years ago
(OrangeWFM bugs not modified in > 2 months)
Status: REOPENED → RESOLVED
Last Resolved: 6 years ago5 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.