Closed Bug 759707 Opened 8 years ago Closed 6 years ago

Intermittent browser_privatebrowsing_ui.js | leaked until shutdown [nsGlobalWindow #2329 about:blank]

Categories

(Firefox :: Private Browsing, defect)

x86
Windows XP
defect
Not set

Tracking

()

RESOLVED WORKSFORME
Tracking Status
firefox15 --- affected
firefox16 --- affected
firefox17 --- affected

People

(Reporter: emorley, Unassigned)

References

Details

(Keywords: intermittent-failure, memory-leak)

https://tbpl.mozilla.org/php/getParsedLog.php?id=12191830&tree=Mozilla-Inbound

[browser/components/privatebrowsing/test/browser/browser_privatebrowsing_ui.js]
  1 window(s) [url = about:blank]
  1 window(s) [url = chrome://browser/content/browser.xul]
Blocks: 438871
Whiteboard: [orange]
https://tbpl.mozilla.org/php/getParsedLog.php?id=12197557&tree=Firefox

[browser/components/privatebrowsing/test/browser/browser_privatebrowsing_ui.js]
  2 window(s) [url = chrome://browser/content/browser.xul]
  2 window(s) [url = about:blank]
https://tbpl.mozilla.org/php/getParsedLog.php?id=12197953&tree=Mozilla-Inbound

[browser/components/privatebrowsing/test/browser/browser_privatebrowsing_ui.js]
  1 window(s) [url = chrome://browser/content/browser.xul]
  1 window(s) [url = about:blank]
https://tbpl.mozilla.org/php/getParsedLog.php?id=12200926&tree=Firefox

[browser/components/privatebrowsing/test/browser/browser_privatebrowsing_ui.js]
  1 window(s) [url = about:blank]
  1 window(s) [url = chrome://browser/content/browser.xul]
https://tbpl.mozilla.org/php/getParsedLog.php?id=12214747&tree=Mozilla-Inbound

[browser/components/privatebrowsing/test/browser/browser_privatebrowsing_ui.js]
  3 window(s) [url = chrome://browser/content/browser.xul]
  3 window(s) [url = about:blank]
https://tbpl.mozilla.org/php/getParsedLog.php?id=12237542&tree=Firefox

[browser/components/privatebrowsing/test/browser/browser_privatebrowsing_ui.js]
  2 window(s) [url = chrome://browser/content/browser.xul]
  2 window(s) [url = about:blank]
https://tbpl.mozilla.org/php/getParsedLog.php?id=12256032&tree=Firefox

[browser/components/privatebrowsing/test/browser/browser_privatebrowsing_ui.js]
  1 window(s) [url = about:blank]
  1 window(s) [url = chrome://browser/content/browser.xul]
https://tbpl.mozilla.org/php/getParsedLog.php?id=12409135&tree=Mozilla-Inbound

[browser/components/privatebrowsing/test/browser/browser_privatebrowsing_ui.js]
  2 window(s) [url = about:blank]
  2 window(s) [url = chrome://browser/content/browser.xul]
https://tbpl.mozilla.org/php/getParsedLog.php?id=12448575&tree=Mozilla-Inbound

[browser/components/privatebrowsing/test/browser/browser_privatebrowsing_ui.js]
  1 window(s) [url = chrome://browser/content/browser.xul]
  1 window(s) [url = about:blank]
https://tbpl.mozilla.org/php/getParsedLog.php?id=12427880&tree=Mozilla-Inbound

[browser/components/privatebrowsing/test/browser/browser_privatebrowsing_ui.js]
  1 window(s) [url = chrome://browser/content/browser.xul]
  1 window(s) [url = about:blank]
https://tbpl.mozilla.org/php/getParsedLog.php?id=12481264&tree=Mozilla-Inbound

[browser/components/privatebrowsing/test/browser/browser_privatebrowsing_ui.js]
  1 window(s) [url = chrome://browser/content/browser.xul]
  1 window(s) [url = about:blank]
https://tbpl.mozilla.org/php/getParsedLog.php?id=12483557&tree=Mozilla-Inbound#error0

[browser/components/privatebrowsing/test/browser/browser_privatebrowsing_ui.js]
  2 window(s) [url = chrome://browser/content/browser.xul]
  2 window(s) [url = about:blank]
https://tbpl.mozilla.org/php/getParsedLog.php?id=12570406&tree=Mozilla-Aurora

[browser/components/privatebrowsing/test/browser/browser_privatebrowsing_ui.js]
  1 window(s) [url = about:blank]
  1 window(s) [url = chrome://browser/content/browser.xul]
https://tbpl.mozilla.org/php/getParsedLog.php?id=12762145&tree=Mozilla-Inbound

[browser/components/privatebrowsing/test/browser/browser_privatebrowsing_ui.js]
  1 window(s) [url = chrome://browser/content/browser.xul]
  1 window(s) [url = about:blank]
https://tbpl.mozilla.org/php/getParsedLog.php?id=12803052&tree=Fx-Team

[browser/components/privatebrowsing/test/browser/browser_privatebrowsing_ui.js]
  1 window(s) [url = about:blank]
  1 window(s) [url = chrome://browser/content/browser.xul]
Hasn't shown up on trunk after bug 728294 landed, so going to call this a false positive and mark WFM for now.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WORKSFORME
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
Summary: Intermittent leak in browser_privatebrowsing_ui.js → Intermittent browser_privatebrowsing_ui.js | leaked until shutdown [nsGlobalWindow #2329 about:blank]
Whiteboard: [orange]
I found a pretty simple way to reproduce this consistently. If anyone wants to work on it, please ping me.
(In reply to Bill McCloskey (:billm) from comment #201)
> I found a pretty simple way to reproduce this consistently. If anyone wants
> to work on it, please ping me.

Ehsan, please may you take a look / assign to someone who can? 
Thank you :-)
Flags: needinfo?(ehsan)
This test will soon be removed.. But I'm curious, Bill.  How do you reliably reproduce this?
Flags: needinfo?(ehsan)
(In reply to Ehsan Akhgari [:ehsan] from comment #203)
> This test will soon be removed.. But I'm curious, Bill.  How do you reliably
> reproduce this?

There are certain circumstances where, before doing a CC, we run a full GC. This is normally very rare, but I was doing some testing where I made it always happen that way. That causes this test to leak reliably.
(In reply to comment #204)
> (In reply to Ehsan Akhgari [:ehsan] from comment #203)
> > This test will soon be removed.. But I'm curious, Bill.  How do you reliably
> > reproduce this?
> 
> There are certain circumstances where, before doing a CC, we run a full GC.
> This is normally very rare, but I was doing some testing where I made it always
> happen that way. That causes this test to leak reliably.

Hmm, that's weird.  Can you please elaborate more?  I'm not sure what this test could be doing to cause that to happen (unless it's uncovering a deeper issue somehow.)
What Bill is saying is that when we trigger a full GC right before a CC (without doing anything in between), then there is a leak.

Normally, this happens only rarely, which would be why it would be an intermittent orange, but Bill had a patch that made this rare circumstance instead always happen.
I see.  CCing smaug.  Who else should know about this?
(OrangeWFM bugs not modified in > 2 months)
Status: REOPENED → RESOLVED
Closed: 7 years ago6 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.