Closed Bug 759723 Opened 12 years ago Closed 12 years ago

Rewrite product name to "Webapp Runtime" in processor when product ID is webapprt@mozilla.org

Categories

(Socorro :: Database, task)

Product:
Socorro
Component:
Database
Type:
task
Priority:
Not set
Severity:
normal

Tracking

(blocking-kilimanjaro:+)

Status:
RESOLVED FIXED
Project Flags:
blocking-kilimanjaro +

People

(Reporter: kairo, Assigned: jberkus)

References

Details

(Whiteboard: [Desktop WebRT], [qa+]) 

This is coming out of the discussion in bug 745980, see there for more info.

In the processor, we need to rewrite the product name of crashes to "Webapp Runtime" when the report has a product ID of webapprt@mozilla.org because on Windows, they dynamically rewrite the product name to the origin of the web app.

The example report at bp-98a96d90-0654-4e9e-8c34-f26832120524 shows how the wrong product name we get looks like.

We can safely overwrite that origin with the correct product name again as we'll get the info of the origin/URL when they fix bug 759502 anyhow.

The question of bug 745980 comment #22 is still pending, but I hope to resolve that today and the question is just if we rewrite to "Webapp Runtime" or to "Firefox".
Blocks: 759724
I sat down with myk and jsmith today and talked about thism and the decision is to go forward with rewriting to "Webapp Runtime" and adding that as a new product to Socorro. (In case the space in the name might be a problem for Socorro, we'll go with "WebappRuntime".)

Laura, Lars, are we able to do that in a way that this is going to production within the next few weeks?
This rewrite of the 'ProductName' to "Webapp Runtime" if 'ProductId' is "webapprt@mozilla.org" can be done just by inserting a row into the Postgres 'product_productid_map' table.  No change to processor code is necessary.  As such, this change can happen at anytime and the effect will be immediate.
Lars, cool, can we do that? Any time would be OK, we already should have the odd report trickling in.
Whiteboard: [Desktop WebRT]
Josh, this should do the trick:

insert into product_productid_map (product_name, productid, rewrite, version_began, version_ended) values ('Webapp Runtime', 'webapprt@mozilla.org', True, 0.0, '');
Component: Backend → Database
QA Contact: backend → database
Assignee: nobody → josh
blocking-kilimanjaro: --- → ?
Josh, hold off for a minute...  

looking at the existing data in the 'product_productid_map' table, I see that the values in the 'productid' column all have braces around them.  Will this new value 'webapprt@mozilla.org' also be equipped with braces?
Going by:
http://mxr.mozilla.org/mozilla-central/source/webapprt/application.ini.in#10

I'd say that no, it will not have braces. (Compare vs. Firefox's ID here: http://mxr.mozilla.org/mozilla-central/source/browser/confvars.sh#33 )

That seems to date back to pre-Mercurial times, so I can say "it's always been that way", so maybe webapprt should have the braces there?
That report in comment #0 has this in the raw JSON:

    "ProductID": "webapprt@mozilla.org"

So, no braces there.
OK, this requires adding WebappRuntime to Socorro first, which is a whole 'nother ball of wax.  We need a spec on the new product first.  Waiting for Kairo.
No longer blocks: 759724
Depends on: 759724
Just FTR and for testing, here's a Mac crash report from Webapp Runtime as well: bp-d3c2839c-681a-43a6-b089-e2e3c2120615 - A Windows report is in comment #0, and bp-543e0469-1555-4fae-bfb3-7dad12120615 is another one.
blocking-kilimanjaro: ? → +
Target Milestone: --- → 14
OK, this is broken on stage.   Fixing.
Kairo, All:

So the assumption that product would be "Firefox" and productid would be "webapprt@mozilla.org" was incorrect.  The actual case for WebRT crashes is:

product = 'Webapp Runtime'
productid = NULL

This brings up another couple issues:

1. We can't have spaces in product names beecause it breaks the current UI.

2. productid is not supposed to be NULL

So, we'll file a bug with the WebRT team for (2).  (1) can be handled with a processor rewrite.
Is there a bug for the product name rewrite in the processor?

Can we work with the NULL productid to begin with?
So the NULL productid is actually bug 768700.  Does it block, or can we work with this for now?
(In reply to Laura Thomson :laura from comment #12)
> Is there a bug for the product name rewrite in the processor?


I take it back.

So this bug is now "Rewrite the product name from 'Webapp Runtime' to 'WebappRuntime'"

Should this be assigned to Lars?
Laura,

No, we already have a way within the existing processor configuration structure to handle the name rewrite, since we already do this for another product.  So that's already been taken care of and is checked in.
This is resolved in 14.0, which is now live.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Umm, what rule are we using here now? Most (i.e. the Windows ones) of our Webapp Runtime crashes do NOT have 'Webapp Runtime' as the product, but something seemingly random, only the Mac and Linux crashes have 'Webapp Runtime' in the product field - right now. We *need* to rewrite based on the product ID being sent to us, that's the only reliable identifier.
(In reply to Robert Kaiser (:kairo@mozilla.com) from comment #17)
> Umm, what rule are we using here now? Most (i.e. the Windows ones) of our
> Webapp Runtime crashes do NOT have 'Webapp Runtime' as the product, but
> something seemingly random, only the Mac and Linux crashes have 'Webapp
> Runtime' in the product field - right now. We *need* to rewrite based on the
> product ID being sent to us, that's the only reliable identifier.

I wonder if that explains why the top crashers is only showing crashes from OS X. I don't see any crashes listed for windows, which seems strange?

https://crash-stats.mozilla.com/topcrasher/byos/WebappRuntime/16.0a1/Mac%20OS%20X/7/browser
Whiteboard: [Desktop WebRT] → [Desktop WebRT], [qa+]
You need to log in before you can comment on or make changes to this bug.