Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Telemetry opt-in looks strange with default window size

RESOLVED FIXED in Thunderbird 16.0

Status

Thunderbird
Mail Window Front End
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mconley, Assigned: andreasn)

Tracking

13 Branch
Thunderbird 16.0
x86
Windows 7
Bug Flags:
in-testsuite -

Thunderbird Tracking Flags

(thunderbird14 fixed, thunderbird15 fixed)

Details

Attachments

(2 attachments)

Created attachment 628330 [details]
The Telemetry opt-in notification with default window size

STR:

1. On Windows 7, create a new Thunderbird profile
2. Set up an account, and close the "Know your rights" notification
3. Close and restart Thunderbird to show the Telemetry opt-in notification

What happens?

The notification looks a bit odd with the default window size - the buttons are cut off at the bottom, and the whole things looks crowded with the status bar. Kinda ugly.

See screenshot.

What's expected?

It should look better. :)
(Assignee)

Comment 1

5 years ago
Here is an approach I tried to take:
white-space: nowrap;
overflow: hidden;
text-overflow: ellipsis;

In order for the text to go... and leave space for the buttons. No cigar so far.
(Assignee)

Comment 2

5 years ago
This seems to be a general problem for notification bars in general, as I ran into this with the latest patch in bug #562048
(Assignee)

Comment 3

5 years ago
Created attachment 634358 [details] [diff] [review]
patch to remove overflow

This removes the overflow-x: hidden; rule from all notification bars introduced with bug #714733 and allows notifications to resize again in order to contain all the elements inside them.
(Assignee)

Comment 4

5 years ago
<florian> andreasn: the notificationbox { overflow-x: hidden; } was added in 2008 for Instantbird (https://hg.instantbird.org/instantbird/rev/43b3e5cd830d) I don't think it's useful anymore.
<florian> the .textbox-textarea was added in 2009 by https://hg.instantbird.org/instantbird/rev/851492a73b19
 apparently we had a pointless horizontal scrollbar at that time, but I don't know if it would reappear if we remove the rule

So we should be safe.
(Assignee)

Updated

5 years ago
Attachment #634358 - Flags: review?(mconley)
Comment on attachment 634358 [details] [diff] [review]
patch to remove overflow

This does the job, thanks!

I think we might want to take this on aurora and beta too - the risk is nil.
Attachment #634358 - Flags: review?(mconley)
Attachment #634358 - Flags: review+
Attachment #634358 - Flags: approval-comm-beta?
Attachment #634358 - Flags: approval-comm-aurora?
Attachment #634358 - Flags: approval-comm-beta?
Attachment #634358 - Flags: approval-comm-beta+
Attachment #634358 - Flags: approval-comm-aurora?
Attachment #634358 - Flags: approval-comm-aurora+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/c5def5a1d5e3
https://hg.mozilla.org/releases/comm-aurora/rev/4c91939a300f
https://hg.mozilla.org/releases/comm-beta/rev/f4b5b44d2f8b
Assignee: nobody → nisses.mail
Status: NEW → RESOLVED
Last Resolved: 5 years ago
status-thunderbird14: --- → fixed
status-thunderbird15: --- → fixed
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 16.0
You need to log in before you can comment on or make changes to this bug.