759797 - App job that creates new versions if manifest has changed is working overtime

Status: RESOLVED FIXED

(Marketplace Graveyard :: Reviewer Tools, defect)

Description

[Andrew Williamson [:eviljeff]]

bug 757557 fixed the cron job so it now runs and creates new versions every day if the manifest has changed.
However, its creating too many versions - seemingly one for every day.

If I had to guess I'd say its either comparing the new manifest with the wrong cached version (maybe the approved public version?), or the cached manifest isn't being saved correctly with the new version.

While extra versions aren't a massive issue it does make the review page difficult to use and it much easier to miss important notes on old versions.

A side effect of the over-active version creation is the queue waiting times all reset each day so it will be impossible to know which have been waiting longest.

Comment 1

[Andy McKay]

Logs show its doing a update each day, it shouldn't be doing that.

Comment 2

[Rob Hudson [:robhudson]]

This commit:
https://github.com/mozilla/zamboni/commit/d7c1b08e2203ff1963f228e2fe48425a931d5000

Changed a lot of this logic... it should only create a new version if it can get the manifest, and if it passes validation, and if its hash differs. It uses the previous version's file as a comparison.

Currently the cron is disabled. Should we re-enable and see how it fares?

Comment 3

[Andrew Williamson [:eviljeff]]

(In reply to Rob Hudson [:robhudson] from comment #2)
> Currently the cron is disabled. Should we re-enable and see how it fares?

Sure, why not!

Comment 4

[Rob Hudson [:robhudson]]

Re-enabled. Leaving bug open for now. It should run at 2:45am.
https://github.com/mozilla/zamboni/commit/a29054c

Comment 5

[Wil Clouser [:clouserw]]

13:31 robhudson | I'd say fixed