Last Comment Bug 759801 - content/media/test/test_playback.html ran additional tests after finish() was called.
: content/media/test/test_playback.html ran additional tests after finish() was...
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Audio/Video (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla15
Assigned To: Mats Palmgren (vacation)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-05-30 09:51 PDT by Mats Palmgren (vacation)
Modified: 2012-06-02 12:02 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Remove the 'timeupdate' event listener when the test is done. (1.66 KB, patch)
2012-05-30 09:55 PDT, Mats Palmgren (vacation)
philringnalda: review+
Details | Diff | Splinter Review

Description Mats Palmgren (vacation) 2012-05-30 09:51:05 PDT
Fallout from the diagnostic patch in bug 677964.

There seems to be a "timeupdate" event coming in after we have
called SimpleTest.finish()

...
93297 INFO TEST-PASS | /tests/content/media/test/test_playback.html | Name should match test.name #2 - detodos.opus should equal detodos.opus
93298 INFO TEST-PASS | /tests/content/media/test/test_playback.html | detodos.opus checking readyState - 2 should equal 2
93299 INFO TEST-PASS | /tests/content/media/test/test_playback.html | detodos.opus shouldn't report NETWORK_LOADED
93300 INFO TEST-PASS | /tests/content/media/test/test_playback.html | detodos.opus checking playback has ended
93301 INFO TEST-PASS | /tests/content/media/test/test_playback.html | [finished detodos.opus-37] Length of array should match number of running tests - 0 should equal 0
93302 INFO TEST-INFO | /tests/content/media/test/test_playback.html | Finished at Tue May 29 2012 20:24:55 GMT-0700 (Pacific Daylight Time) (1338348295.298s)
93303 INFO TEST-INFO | /tests/content/media/test/test_playback.html | Running time: 38.02s
93304 INFO TEST-PASS | /tests/content/media/test/test_playback.html | Name should match test.name #4 - detodos.opus should equal detodos.opus
93305 INFO TEST-PASS | /tests/content/media/test/test_playback.html | detodos.opus duration (2.9135) should be around 2.9135
93306 INFO TEST-PASS | /tests/content/media/test/test_playback.html | detodos.opus time should run forwards: p=2.9135 c=2.9135
93307 INFO TEST-END | /tests/content/media/test/test_playback.html | finished in 38103ms
93308 INFO TEST-START | /tests/content/media/test/test_playback_errors.html
93309 ERROR TEST-UNEXPECTED-FAIL | /tests/content/media/test/test_playback_errors.html | [onunload] /tests/content/media/test/test_playback.html ran additional tests after finish() was called.
Comment 1 Mats Palmgren (vacation) 2012-05-30 09:55:42 PDT
Created attachment 628367 [details] [diff] [review]
Remove the 'timeupdate' event listener when the test is done.
Comment 2 Mats Palmgren (vacation) 2012-05-30 13:06:24 PDT
https://tbpl.mozilla.org/?usebuildbot=1&tree=Try&rev=b94c04bcd331
Comment 4 :Ehsan Akhgari (away Aug 1-5) 2012-06-02 12:02:51 PDT
https://hg.mozilla.org/mozilla-central/rev/326e101b7a6c

Note You need to log in before you can comment on or make changes to this bug.