Persona is no longer an option for authentication on BMO. For more details see Persona Deprecated.
Last Comment Bug 759817 - Repair an inheritance issue
: Repair an inheritance issue
Product: Core
Classification: Components
Component: Disability Access APIs (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla16
Assigned To: Mark Capella [:capella]
: alexander :surkov
Depends on:
  Show dependency treegraph
Reported: 2012-05-30 10:36 PDT by Mark Capella [:capella]
Modified: 2012-06-13 05:58 PDT (History)
3 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Patch (v1) (1.95 KB, patch)
2012-06-11 21:00 PDT, Mark Capella [:capella]
tbsaunde+mozbugs: review+
Details | Diff | Splinter Review

Description Mark Capella [:capella] 2012-05-30 10:36:16 PDT
accessible/src/html/nsHTMLCanvasAccessible.h defines class nsHTMLCanvasAccessible that inherits from HyperTextAccessible.

This needs to be changed to be inherited from HyperTextAccessibleWrap.

>  /**
>   * HTML canvas accessible (html:canvas).
>   */
> +class nsHTMLCanvasAccessible : public HyperTextAccessible
Comment 1 Mark Capella [:capella] 2012-06-11 21:00:30 PDT
Created attachment 632119 [details] [diff] [review]
Patch (v1)

Following up with leftover "to-do".
Comment 2 Trevor Saunders (:tbsaunde) 2012-06-12 01:46:23 PDT
Comment on attachment 632119 [details] [diff] [review]
Patch (v1)

> HTMLCanvasAccessible::
>   HTMLCanvasAccessible(nsIContent* aContent, DocAccessible* aDoc) :
>-  HyperTextAccessible(aContent, aDoc)
>+  HyperTextAccessibleWrap(aContent, aDoc)
> {
> }

since its trivial you could consider inlining it while your here, but up to you.

>+NS_IMPL_ISUPPORTS_INHERITED0(HTMLCanvasAccessible, HyperTextAccessible)

curious why you add this.
Comment 3 Mark Capella [:capella] 2012-06-12 01:54:47 PDT
build failed without it ... took a shot - put it in, build worked ... want me to get you the error code?
Comment 4 Trevor Saunders (:tbsaunde) 2012-06-12 01:59:50 PDT
(In reply to Mark Capella [:capella] from comment #3)
> build failed without it ... took a shot - put it in, build worked ... want
> me to get you the error code?

if its not too hard I'm curious, but I don't think its a huge deal.
Comment 5 Mark Capella [:capella] 2012-06-12 02:23:46 PDT
It failed in the build / link step ... I was doing a side by side compare to HTMLListAccessible.cpp and found the macro was absent in HTMLCanvassAccessible, so I added it and basically got lucky.
Comment 6 Mark Capella [:capella] 2012-06-12 08:28:31 PDT
Comment 7 Mark Capella [:capella] 2012-06-12 16:37:55 PDT
Comment 8 Ed Morley (Away 28th Oct -> 6th Nov) [:emorley] 2012-06-13 05:58:17 PDT

Note You need to log in before you can comment on or make changes to this bug.