The default bug view has changed. See this FAQ.

Repair an inheritance issue

RESOLVED FIXED in mozilla16

Status

()

Core
Disability Access APIs
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: capella, Assigned: capella)

Tracking

unspecified
mozilla16
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [lang=c++])

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
accessible/src/html/nsHTMLCanvasAccessible.h defines class nsHTMLCanvasAccessible that inherits from HyperTextAccessible.

This needs to be changed to be inherited from HyperTextAccessibleWrap.

>  /**
>   * HTML canvas accessible (html:canvas).
>   */
> +class nsHTMLCanvasAccessible : public HyperTextAccessible
(Assignee)

Comment 1

5 years ago
Created attachment 632119 [details] [diff] [review]
Patch (v1)

Following up with leftover "to-do".
Assignee: nobody → markcapella
Status: NEW → ASSIGNED
Attachment #632119 - Flags: review?(surkov.alexander)
Comment on attachment 632119 [details] [diff] [review]
Patch (v1)

> HTMLCanvasAccessible::
>   HTMLCanvasAccessible(nsIContent* aContent, DocAccessible* aDoc) :
>-  HyperTextAccessible(aContent, aDoc)
>+  HyperTextAccessibleWrap(aContent, aDoc)
> {
> }

since its trivial you could consider inlining it while your here, but up to you.

> 
>+NS_IMPL_ISUPPORTS_INHERITED0(HTMLCanvasAccessible, HyperTextAccessible)

curious why you add this.
Attachment #632119 - Flags: review?(surkov.alexander) → review+
(Assignee)

Comment 3

5 years ago
build failed without it ... took a shot - put it in, build worked ... want me to get you the error code?
(In reply to Mark Capella [:capella] from comment #3)
> build failed without it ... took a shot - put it in, build worked ... want
> me to get you the error code?

if its not too hard I'm curious, but I don't think its a huge deal.
(Assignee)

Comment 5

5 years ago
It failed in the build / link step ... I was doing a side by side compare to HTMLListAccessible.cpp and found the macro was absent in HTMLCanvassAccessible, so I added it and basically got lucky.

http://pastebin.mozilla.org/1661090
(Assignee)

Comment 6

5 years ago
https://tbpl.mozilla.org/?tree=Try&rev=4d74c5630999
(Assignee)

Comment 7

5 years ago
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=5387220c0609
Target Milestone: --- → mozilla16
https://hg.mozilla.org/mozilla-central/rev/5387220c0609
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.