759817 - Repair an inheritance issue

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Mark Capella [:capella]]

accessible/src/html/nsHTMLCanvasAccessible.h defines class nsHTMLCanvasAccessible that inherits from HyperTextAccessible.

This needs to be changed to be inherited from HyperTextAccessibleWrap.

>  /**
>   * HTML canvas accessible (html:canvas).
>   */
> +class nsHTMLCanvasAccessible : public HyperTextAccessible

Comment 1

[Mark Capella [:capella]]

Attachment: Patch (v1)

Following up with leftover "to-do".

Comment 2

[Trevor Saunders (:tbsaunde)]

Comment on attachment 632119 [details] [diff] [review]
Patch (v1)

> HTMLCanvasAccessible::
>   HTMLCanvasAccessible(nsIContent* aContent, DocAccessible* aDoc) :
>-  HyperTextAccessible(aContent, aDoc)
>+  HyperTextAccessibleWrap(aContent, aDoc)
> {
> }

since its trivial you could consider inlining it while your here, but up to you.

> 
>+NS_IMPL_ISUPPORTS_INHERITED0(HTMLCanvasAccessible, HyperTextAccessible)

curious why you add this.

Comment 3

[Mark Capella [:capella]]

build failed without it ... took a shot - put it in, build worked ... want me to get you the error code?

Comment 4

[Trevor Saunders (:tbsaunde)]

(In reply to Mark Capella [:capella] from comment #3)
> build failed without it ... took a shot - put it in, build worked ... want
> me to get you the error code?

if its not too hard I'm curious, but I don't think its a huge deal.

Comment 5

[Mark Capella [:capella]]

It failed in the build / link step ... I was doing a side by side compare to HTMLListAccessible.cpp and found the macro was absent in HTMLCanvassAccessible, so I added it and basically got lucky.

http://pastebin.mozilla.org/1661090

Comment 6

[Mark Capella [:capella]]

https://tbpl.mozilla.org/?tree=Try&rev=4d74c5630999

Comment 7

[Mark Capella [:capella]]

https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=5387220c0609

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/5387220c0609