This bug is to actually enable IBMBIDI in the build.
I will make all bugs that are fixed by the IBMBIDI code dependent on this bug.
Created attachment 31652 [details] [diff] [review]
how to turn on IBMBIDI ifdef by default on the Mac
Created attachment 31656 [details] [diff] [review]
how to turn on IBMBIDI ifdef by default on Linux
Created attachment 31660 [details] [diff] [review]
how to turn on IBMBIDI ifdef by default on Windows
Chris, would you please take a look at the Linux and Windows patches in this
bug report, and let me know if they look OK?
Autoconf will be run automatically to create a new configure, right? (Once I
By the way, we're not ready to turn on IBMBIDI by default. I just want to make
sure we have the right patches in here, that's all.
The patches look right to me.
Created attachment 32213 [details] [diff] [review]
before turning on IBMBIDI, we need these makefile.win changes
cls, please review the most recent makefile.win patch. I found that I had to
make these changes in order to turn on the IBMBIDI ifdef by default. In most
cases, I'm just adding an include for config.mak (hopefully in the right place).
But in one case, I'm also changing INCS to LINCS. Are you a Windows makefile
expert? If not, do you know who should review these? Thanks.
leaf would be the preferred person to review win32 makefile changes.
Hi Leaf, would you please review the 4th patch (makefile.win changes)? Thanks!
ask leaf to review
I'm shocked that these makefile.win files didn't have config.mak included in the
first place, so r=leaf for
check in http://bugzilla.mozilla.org/showattachment.cgi?attach_id=32213
done. mark this bug fixed
Changing component to BiDi and adding keyword intl.
Changing QA contact to default Bidi-Hebrew owner email@example.com.