[BiDi] Turn on the IBMBIDI #ifdef

VERIFIED FIXED

Status

()

Core
Layout: Text
VERIFIED FIXED
17 years ago
9 years ago

People

(Reporter: mkaply, Assigned: mkaply)

Tracking

({intl})

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: ask leaf to review 2001-05-07 19:00)

Attachments

(4 attachments)

(Assignee)

Description

17 years ago
This bug is to actually enable IBMBIDI in the build.

I will make all bugs that are fixed by the IBMBIDI code dependent on this bug.
(Assignee)

Updated

17 years ago
Blocks: 3687
(Assignee)

Updated

17 years ago
Blocks: 73872
(Assignee)

Updated

17 years ago
Blocks: 64490
(Assignee)

Updated

17 years ago
Blocks: 26371
(Assignee)

Updated

17 years ago
Blocks: 24199
(Assignee)

Updated

17 years ago
Blocks: 17175
(Assignee)

Updated

17 years ago
Status: NEW → ASSIGNED
(Assignee)

Updated

17 years ago
Blocks: 35028
(Assignee)

Updated

17 years ago
Blocks: 74063
(Assignee)

Updated

17 years ago
Blocks: 62134
(Assignee)

Updated

17 years ago
Blocks: 51916

Comment 1

17 years ago
Created attachment 31652 [details] [diff] [review]
how to turn on IBMBIDI ifdef by default on the Mac

Comment 2

17 years ago
Created attachment 31656 [details] [diff] [review]
how to turn on IBMBIDI ifdef by default on Linux

Comment 3

17 years ago
Created attachment 31660 [details] [diff] [review]
how to turn on IBMBIDI ifdef by default on Windows

Comment 4

17 years ago
Chris, would you please take a look at the Linux and Windows patches in this
bug report, and let me know if they look OK?

Autoconf will be run automatically to create a new configure, right? (Once I
check in.)

By the way, we're not ready to turn on IBMBIDI by default. I just want to make
sure we have the right patches in here, that's all.

Comment 5

17 years ago
The patches look right to me.

Updated

17 years ago
Summary: Turn on the IBMBIDI #ifdef → [BiDi] Turn on the IBMBIDI #ifdef

Comment 6

17 years ago
Created attachment 32213 [details] [diff] [review]
before turning on IBMBIDI, we need these makefile.win changes

Comment 7

17 years ago
cls, please review the most recent makefile.win patch. I found that I had to
make these changes in order to turn on the IBMBIDI ifdef by default. In most
cases, I'm just adding an include for config.mak (hopefully in the right place).
But in one case, I'm also changing INCS to LINCS. Are you a Windows makefile
expert? If not, do you know who should review these? Thanks.

Updated

17 years ago
Depends on: 76931, 76933, 76939, 77190

Comment 8

17 years ago
leaf would be the preferred person to review win32 makefile changes.

Comment 9

17 years ago
Hi Leaf, would you please review the 4th patch (makefile.win changes)? Thanks!

Updated

17 years ago
No longer depends on: 76931

Updated

17 years ago
No longer depends on: 77190

Updated

17 years ago
Depends on: 7693, 74587
No longer depends on: 76939

Updated

17 years ago
No longer depends on: 74587
(Assignee)

Updated

17 years ago
Depends on: 74587, 76939
No longer depends on: 7693

Updated

17 years ago
No longer depends on: 74587

Comment 10

17 years ago
ask leaf to review 

Updated

17 years ago
Whiteboard: ask leaf to review 2001-05-07 19:00

Comment 11

17 years ago
I'm shocked that these makefile.win files didn't have config.mak included in the
first place, so r=leaf for
http://bugzilla.mozilla.org/showattachment.cgi?attach_id=32213

Comment 12

17 years ago
check in http://bugzilla.mozilla.org/showattachment.cgi?attach_id=32213

Comment 13

17 years ago
done. mark this bug fixed
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Comment 14

16 years ago
Changing component to BiDi and adding keyword intl.
Component: Internationalization → BiDi Hebrew & Arabic
Keywords: intl

Comment 15

16 years ago
Changing QA contact to default Bidi-Hebrew owner giladehven@hotmail.com.
QA Contact: andreasb → giladehven
(Assignee)

Comment 16

16 years ago
Verified fixed
Status: RESOLVED → VERIFIED

Updated

9 years ago
Component: Layout: BiDi Hebrew & Arabic → Layout: Text
QA Contact: giladehven → layout.fonts-and-text
You need to log in before you can comment on or make changes to this bug.