75982 - [BiDi] Turn on the IBMBIDI #ifdef

Status: VERIFIED FIXED

(Core :: Layout: Text and Fonts, defect)

Description

[Mike Kaply [:mkaply]]

This bug is to actually enable IBMBIDI in the build.

I will make all bugs that are fixed by the IBMBIDI code dependent on this bug.

Comment 1

[Erik van der Poel]

Attachment: how to turn on IBMBIDI ifdef by default on the Mac

Comment 2

[Erik van der Poel]

Attachment: how to turn on IBMBIDI ifdef by default on Linux

Comment 3

[Erik van der Poel]

Attachment: how to turn on IBMBIDI ifdef by default on Windows

Comment 4

[Erik van der Poel]

Chris, would you please take a look at the Linux and Windows patches in this
bug report, and let me know if they look OK?

Autoconf will be run automatically to create a new configure, right? (Once I
check in.)

By the way, we're not ready to turn on IBMBIDI by default. I just want to make
sure we have the right patches in here, that's all.

Comment 5

[cls]

The patches look right to me.

Comment 6

[Erik van der Poel]

Attachment: before turning on IBMBIDI, we need these makefile.win changes

Comment 7

[Erik van der Poel]

cls, please review the most recent makefile.win patch. I found that I had to
make these changes in order to turn on the IBMBIDI ifdef by default. In most
cases, I'm just adding an include for config.mak (hopefully in the right place).
But in one case, I'm also changing INCS to LINCS. Are you a Windows makefile
expert? If not, do you know who should review these? Thanks.

Comment 8

[cls]

leaf would be the preferred person to review win32 makefile changes.

Comment 9

[Erik van der Poel]

Hi Leaf, would you please review the 4th patch (makefile.win changes)? Thanks!

Comment 10

[Frank Tang]

ask leaf to review 

Comment 11

[Daniel (Leaf) Nunes]

I'm shocked that these makefile.win files didn't have config.mak included in the
first place, so r=leaf for
http://bugzilla.mozilla.org/showattachment.cgi?attach_id=32213

Comment 12

[Frank Tang]

check in http://bugzilla.mozilla.org/showattachment.cgi?attach_id=32213

Comment 13

[Frank Tang]

done. mark this bug fixed

Comment 14

[Andreas Becker]

Changing component to BiDi and adding keyword intl.

Comment 15

[Andreas Becker]

Changing QA contact to default Bidi-Hebrew owner [e-mail].

Comment 16

[Mike Kaply [:mkaply]]

Verified fixed