mozprocess should copy os.environ at instance-creation time, not at module load time

RESOLVED FIXED

Status

Testing
Mozbase
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Jeff Hammel, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
https://github.com/mozilla/mozbase/blob/master/mozprocess/mozprocess/processhandler.py#L486

This makes the default argument whatever os.environ is at module load
time.  Instead, it should probably be whatever os.environ is at
instance creation time
(Reporter)

Updated

6 years ago
Blocks: 759825
(Reporter)

Comment 1

6 years ago
Created attachment 628396 [details] [diff] [review]
do this thing the bug title describes
Attachment #628396 - Flags: review?(wlachance)
Comment on attachment 628396 [details] [diff] [review]
do this thing the bug title describes

LGTM
Attachment #628396 - Flags: review?(wlachance) → review+
(Reporter)

Comment 3

6 years ago
pushed: https://github.com/mozilla/mozbase/commit/31b9f54b42c9d8d3d2d9d19052d157add57c52e8
Thanks!
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.