759854 - Using the system proxy should honor the no_pxoxies list when system proxy settings are enabled

Status: RESOLVED INVALID

(Core :: Networking, defect)

Description

[Mike Kaply [:mkaply]]

Looking at the code in nsProtocolProxyService.cpp

http://mxr.mozilla.org/mozilla-central/source/netwerk/base/src/nsProtocolProxyService.cpp#1277

The preference network.proxy.no_proxies_on is honored in either the direct case or manual proxy case.

If we honor no_proxies_on for direct (which I have to admit I don't completely understand), we should honor no_proxies_on for system especially on Windows where you can't specify server to not use a proxy on at the system level.

Comment 1

[James Ross]

Internet Options > Connections > LAN Settings > (Proxy server) Advanced > Exceptions would be where you set the "no_proxies_on" equivalent in Windows. Whether it is easy/possible/worthwhile using that in Firefox rather than the Firefox preference is another question.

Comment 2

[Masatoshi Kimura [:emk]]

Out system proxy settings code already looks at the proxy override from the system settings.
https://mxr.mozilla.org/mozilla-central/source/toolkit/system/windowsproxy/nsWindowsSystemProxySettings.cpp#115
It would be very confusing if the system settings and the Firefox settings are mixed.