759920 - When interacting with elements that are disabled am not getting a error status

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[David Burns :automatedtester]

Noticed when working with Selenium proxy on tests that should throw a specific error are not getting it. e.g.

2012-05-30 22:58:28,456 - Selenium-Proxy - INFO - Clearing {9f51b9ef-773b-cc4a-a57a-ada29af593ce} - 13
2012-05-30 22:58:28,460 - Selenium-Proxy - CRITICAL - Server Exception: Traceback (most recent call last):
  File "selenium_proxy.py", line 202, in do_POST
    marionette_element.clear()
  File "/Users/davidburns/.virtualenvs/seleniumproxy/lib/python2.7/site-packages/marionette-0.2-py2.7.egg/marionette/marionette.py", line 89, in clear
    return self.marionette._send_message('clearElement', 'ok', element=self.id)
  File "/Users/davidburns/.virtualenvs/seleniumproxy/lib/python2.7/site-packages/marionette-0.2-py2.7.egg/marionette/marionette.py", line 169, in _send_message
    self._handle_error(response)
  File "/Users/davidburns/.virtualenvs/seleniumproxy/lib/python2.7/site-packages/marionette-0.2-py2.7.egg/marionette/marionette.py", line 216, in _handle_error
    raise MarionetteException(message=message, status=status, stacktrace=stacktrace)
MarionetteException: Element must be user-editable in order to clear it.
stacktrace:
        y@chrome://marionette/content/atoms.js:7
        id@chrome://marionette/content/atoms.js:73
        @chrome://marionette/content/atoms.js:74
        @chrome://marionette/content/atoms.js:74
        clearElement@chrome://marionette/content/marionette-listener.js:599

This should be InvalidStateException and the issue is that the response from Gecko does not have the status so when it goes into _handle_error it just falls right through to the catch all and that is what gets thrown.

Test cases to follow

Comment 1

[David Burns :automatedtester]

Attachment: test cases

Comment 3

[David Burns :automatedtester]

Attachment: Tests and fixes that show this error

Comment 4

[Malini Das [:mdas] - Away, not checking bugmail]

Comment on attachment 633531 [details] [diff] [review]
Tests and fixes that show this error

Review of attachment 633531 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the patch!

::: testing/marionette/client/marionette/www/test_clearing.html
@@ +17,5 @@
> +      text area which is not supposed to be cleared</textarea>
> +
> +    <div id="content-editable" contentEditable="true">This is a contentEditable area</div>
> +  </body>
> +</html>

We should add the MPL license to this file like the others in the www dir

Comment 5

[David Burns :automatedtester]

Landed in http://hg.mozilla.org/mozilla-central/rev/da85d45f39ef