759933 - Remove excessive logging in PanZoomController

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Benoit Girard (:BenWa)]

Attachment: patch

Comment 1

[Benoit Girard (:BenWa)]

adb lolcat looks bad and we should feel bad </meme>

I/GeckoPanZoomController( 3153): Got message: Preferences:Data
I/GeckoPanZoomController( 3153): Zoom animation frames: [0.0, 0.10211, 0.19864, 0.29043, 0.37816, 0.46155, 0.54054, 0.61496, 0.68467, 0.7491, 0.80794, 0.86069, 0.90651, 0.94471, 0.97401, 0.99309]
D/GeckoPanZoomController( 3153): generating valid viewport using v=RectF(0.0, 0.0, 480.0, 690.0) p=(980.0,1633.0) c=(980.0,1633.3334) z=1.0
D/GeckoPanZoomController( 3153): generated valid viewport as v=RectF(0.0, 0.0, 480.0, 690.0) p=(980.0,1633.0) c=(980.0,1633.3334) z=1.0
D/GeckoPanZoomController( 3153): generating valid viewport using v=RectF(0.0, 0.0, 480.0, 690.0) p=(480.0,690.0) c=(1024.0,1472.0) z=0.46874997
D/GeckoPanZoomController( 3153): generated valid viewport as v=RectF(0.0, 0.0, 480.0, 690.0) p=(480.0,690.0) c=(1024.0,1472.0) z=0.46874997
D/GeckoPanZoomController( 3153): generating valid viewport using v=RectF(0.0, 0.0, 480.0, 690.0) p=(480.0,1581.0) c=(1024.0,3373.0) z=0.46874997
D/GeckoPanZoomController( 3153): generated valid viewport as v=RectF(0.0, 0.0, 480.0, 690.0) p=(480.0,1581.0) c=(1024.0,3373.0) z=0.46874997
D/GeckoPanZoomController( 3153): generating valid viewport using v=RectF(0.0, 0.0, 480.0, 690.0) p=(480.0,1590.0) c=(1024.0,3391.0) z=0.46874997
D/GeckoPanZoomController( 3153): generated valid viewport as v=RectF(0.0, 0.0, 480.0, 690.0) p=(480.0,1590.0) c=(1024.0,3391.0) z=0.46874997
D/GeckoPanZoomController( 3153): generating valid viewport using v=RectF(0.0, 1099.9429, 480.0, 1789.9426) p=(480.0,1721.0) c=(1024.0,3671.0) z=0.46874997
D/GeckoPanZoomController( 3153): generated valid viewport as v=RectF(0.0, 1031.0002, 480.0, 1721.0) p=(480.0,1721.0) c=(1024.0,3671.0) z=0.46874997
D/GeckoPanZoomController( 3153): Finishing animation at org.mozilla.gecko.gfx.ImmutableViewportMetrics@405dcfa0
D/GeckoPanZoomController( 3153): generating valid viewport using v=RectF(0.0, 1031.0002, 480.0, 1721.0) p=(480.0,1625.0) c=(1024.0,3466.0) z=0.46874997
D/GeckoPanZoomController( 3153): generated valid viewport as v=RectF(0.0, 935.00024, 480.0, 1625.0) p=(480.0,1625.0) c=(1024.0,3466.0) z=0.46874997
D/GeckoPanZoomController( 3153): generating valid viewport using v=RectF(0.0, 935.00024, 480.0, 1625.0) p=(480.0,1648.0) c=(1024.0,3516.0) z=0.46874997
D/GeckoPanZoomController( 3153): generated valid viewport as v=RectF(0.0, 935.00024, 480.0, 1625.0) p=(480.0,1648.0) c=(1024.0,3516.0) z=0.46874997
D/GeckoPanZoomController( 3153): generating valid viewport using v=RectF(0.0, 935.00024, 480.0, 1625.0) p=(480.0,1640.0) c=(1024.0,3498.0) z=0.46874997
D/GeckoPanZoomController( 3153): generated valid viewport as v=RectF(0.0, 935.00024, 480.0, 1625.0) p=(480.0,1640.0) c=(1024.0,3498.0) z=0.46874997
D/GeckoPanZoomController( 3153): generating valid viewport using v=RectF(0.0, -60.387817, 480.0, 629.6122) p=(480.0,1640.0) c=(1024.0,3498.0) z=0.46874997
D/GeckoPanZoomController( 3153): generated valid viewport as v=RectF(0.0, 0.0, 480.0, 690.0) p=(480.0,1640.0) c=(1024.0,3498.0) z=0.46874997
D/GeckoPanZoomController( 3153): Finishing animation at org.mozilla.gecko.gfx.ImmutableViewportMetrics@405d9738
D/GeckoPanZoomController( 3153): generating valid viewport using v=RectF(0.0, 1102.0507, 480.0, 1792.0508) p=(480.0,1640.0) c=(1024.0,3498.0) z=0.46874997
D/GeckoPanZoomController( 3153): generated valid viewport as v=RectF(0.0, 949.9999, 480.0, 1640.0) p=(480.0,1640.0) c=(1024.0,3498.0) z=0.46874997
D/GeckoPanZoomController( 3153): Finishing animation at org.mozilla.gecko.gfx.ImmutableViewportMetrics@4059c748
D/GeckoPanZoomController( 3153): Finishing animation at org.mozilla.gecko.gfx.ImmutableViewportMetrics@4059aae0
D/GeckoPanZoomController( 3153): generating valid viewport using v=RectF(0.0, 1018.2787, 480.0, 1708.279) p=(480.0,1640.0) c=(1024.0,3498.0) z=0.46874997
D/GeckoPanZoomController( 3153): generated valid viewport as v=RectF(0.0, 949.99963, 480.0, 1640.0) p=(480.0,1640.0) c=(1024.0,3498.0) z=0.46874997
D/GeckoPanZoomController( 3153): Finishing animation at org.mozilla.gecko.gfx.ImmutableViewportMetrics@405eb338
D/GeckoPanZoomController( 3153): onScale in state PINCHING

(Repeated a few hundread times)

D/GeckoPanZoomController( 3153): onScale in state PINCHING
D/GeckoPanZoomController( 3153): onScale in state PINCHING
D/GeckoPanZoomController( 3153): onScale in state PINCHING
D/GeckoPanZoomController( 3153): onScale in state PINCHING
D/GeckoPanZoomController( 3153): onScaleEnd in PINCHING
D/GeckoPanZoomController( 3153): generating valid viewport using v=RectF(184.59149, 1862.7249, 664.59143, 2552.7239) p=(801.29285,2737.229) c=(1024.0,3498.0) z=0.78251255
D/GeckoPanZoomController( 3153): generated valid viewport as v=RectF(184.59149, 1862.7249, 664.59143, 2552.7239) p=(801.29285,2737.229) c=(1024.0,3498.0) z=0.78251255
D/GeckoPanZoomController( 3153): generating valid viewport using v=RectF(184.59149, 1862.7249, 664.59143, 2552.7239) p=(801.0,2737.0) c=(1024.0,3498.0) z=0.78251255
D/GeckoPanZoomController( 3153): generated valid viewport as v=RectF(184.59149, 1862.7249, 664.59143, 2552.7239) p=(801.0,2737.0) c=(1024.0,3498.0) z=0.78251255

Comment 2

[Benoit Girard (:BenWa)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/966f5f106394

Comment 3

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/966f5f106394