76001 - prompt method of nsIPrompt interface doesnot use default title when checkMsg is null

Status: VERIFIED FIXED

(Core Graveyard :: Embedding: APIs, defect)

Description

[dsirnapalli]

when checkMsg is null in the below method it should use default title.
boolean prompt(in wstring dialogTitle,in wstring text,inout wstring value,
               in wstring checkMsg, inout boolean checkValue);
when i used the test case below
var boo = promptObj.prompt("prompt dialog", "text message",
                             val, null, checkbox);

its not showing the default title and also its not showing checkbox.

Comment 1

[dsirnapalli]

-- reassigned as per jud's suggestion.

Comment 2

[Conrad Carlen (not reading bugmail)]

Yep, according to the comments, that's wrong. I'll fix it to do what it says it
will do.

Comment 3

[Conrad Carlen (not reading bugmail)]

The comment in the API will have to change, not the code. The idea was, if
checkMsg == null && checkValue != null, to use a default title for the checkbox.
Since checkValue is an inout param, it isn't possible to pass null from JS as it
is from C++. So, the prompt implementation requires both the message and the
value to be non-null in order to show the checkbox.

Comment 4

[Conrad Carlen (not reading bugmail)]

Attachment: makes comments accurate with reality

Comment 5

[Conrad Carlen (not reading bugmail)]

Dan - can you review this one? The comments in the .idl are just wrong. Using a
default checkbox title if the caller passed null seemed like a good idea at some
point, but by the time I worked on the implementation had changed my mind.

Comment 6

[Dan M]

r=me

Comment 7

[Conrad Carlen (not reading bugmail)]

*** Bug 75998 has been marked as a duplicate of this bug. ***

Comment 8

[Conrad Carlen (not reading bugmail)]

CC'ing Alec for sr.

Comment 9

[Alec Flett]

sr=alecf

Comment 10

[Conrad Carlen (not reading bugmail)]

Got sr - ready to go.

Comment 11

[Conrad Carlen (not reading bugmail)]

Fix checked in.

Comment 12

[dsirnapalli]

-- verified.