Make nsIMozSmsRequest inherit from nsIDOMDOMRequest

RESOLVED FIXED in mozilla16

Status

()

Core
DOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mounir, Assigned: mounir)

Tracking

({dev-doc-complete})

Trunk
mozilla16
dev-doc-complete
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 628624 [details] [diff] [review]
Patch v1

So we are sure to share the same interface and be recognized as sharing it (|request instanceof DOMRequest| would return true). It seems to be a good compromise compared to the highly time consuming and risky work happening in bug 749086.
Attachment #628624 - Flags: review?(jonas)
Comment on attachment 628624 [details] [diff] [review]
Patch v1

Review of attachment 628624 [details] [diff] [review]:
-----------------------------------------------------------------

This seems fine, but is there a reason to keep the SmsRequest interface at all?
Attachment #628624 - Flags: review?(jonas) → review+
(Assignee)

Comment 2

5 years ago
(In reply to Jonas Sicking (:sicking) Vacation June 11-22 from comment #1)
> Comment on attachment 628624 [details] [diff] [review]
> Patch v1
> 
> Review of attachment 628624 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> This seems fine, but is there a reason to keep the SmsRequest interface at
> all?

Getting ride of nsIDOMSmsRequest isn't a trival work. We have a bug for that but having nsIDOMSmsRequest inheriting from nsIDOMDOMRequest is a good middle ground. I wonder how important that would be to remove nsIDOMSmsRequest for v1 knowing those changes will need to be backed and might create regressions.
(Assignee)

Updated

5 years ago
Target Milestone: --- → mozilla16
(Assignee)

Updated

5 years ago
Attachment #628624 - Flags: checkin+
It's definitely not important. I just figured a search'n'replace would work, but if there's non-trivial work involved here I agree we should punt.
https://hg.mozilla.org/mozilla-central/rev/5a489379b537
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Keywords: dev-doc-needed
https://developer.mozilla.org/en-US/docs/Firefox_16_for_developers#DOM
https://developer.mozilla.org/en-US/docs/DOM/SmsRequest
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.