760011 - Make nsIMozSmsRequest inherit from nsIDOMDOMRequest

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Mounir Lamouri (:mounir)]

Attachment: Patch v1

So we are sure to share the same interface and be recognized as sharing it (|request instanceof DOMRequest| would return true). It seems to be a good compromise compared to the highly time consuming and risky work happening in bug 749086.

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 628624 [details] [diff] [review]
Patch v1

Review of attachment 628624 [details] [diff] [review]:
-----------------------------------------------------------------

This seems fine, but is there a reason to keep the SmsRequest interface at all?

Comment 2

[Mounir Lamouri (:mounir)]

(In reply to Jonas Sicking (:sicking) Vacation June 11-22 from comment #1)
> Comment on attachment 628624 [details] [diff] [review]
> Patch v1
> 
> Review of attachment 628624 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> This seems fine, but is there a reason to keep the SmsRequest interface at
> all?

Getting ride of nsIDOMSmsRequest isn't a trival work. We have a bug for that but having nsIDOMSmsRequest inheriting from nsIDOMDOMRequest is a good middle ground. I wonder how important that would be to remove nsIDOMSmsRequest for v1 knowing those changes will need to be backed and might create regressions.

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

It's definitely not important. I just figured a search'n'replace would work, but if there's non-trivial work involved here I agree we should punt.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5a489379b537

Comment 5

[Florian Scholz (Open Web Docs)]

https://developer.mozilla.org/en-US/docs/Firefox_16_for_developers#DOM
https://developer.mozilla.org/en-US/docs/DOM/SmsRequest