760021 - rsync-motd is broken for mozilla-releases and mozilla-current

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[Nick Thomas [:nthomas] (UTC+12)]

I trimmed the modules today and it's still reporting
                     mozilla-releases: 132GB
                       mozilla-current: 31GB

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: [svn] rework motd

Lots of historical cruft getting the chop here, in favour of doing rsync -n and parsing the lines like this:
 total size is 194350446326  speedup is 64600.04 (DRY RUN)

Comment 2

[Rail Aliiev [:rail]]

Comment on attachment 628634 [details] [diff] [review]
[svn] rework motd

Review of attachment 628634 [details] [diff] [review]:
-----------------------------------------------------------------

::: manifests/upload_cron.pp
@@ +55,2 @@
>              mode => 755,
>              source => "puppet:///modules/productdelivery/bin/get-prereleases-size";

I'm not sure if I understand this part.

It looks like you're removing get-prereleases-size in your patch (or trimming the file to 0, depending on how you apply the patch), but here you are trying to use the content of removed file...

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: [svn] rework motd, v2

Good catch, this fixes that up.

Comment 4

[Rail Aliiev [:rail]]

hmmm, I'm still getting errors trying to apply the patch:

$ svn co svn+ssh://svn.mozilla.org/sysadmins/puppet/trunk/modules/productdelivery
$ wget -O - https://bug760021.bugzilla.mozilla.org/attachment.cgi?id=628965 | patch -p0
patching file files/cron.d/motd-gen
patching file files/bin/get-prereleases-size
patching file files/bin/motd-gen.sh
can't find file to patch at input line 84
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|Index: files/bin/get-rsync-module-size
|===================================================================
|--- files/bin/get-rsync-module-size	(revision 39606)
|+++ files/bin/get-rsync-module-size	(working copy)
--------------------------
File to patch: 
Skip this patch? [y] 


Any ideas why it happens?

Comment 5

[Rail Aliiev [:rail]]

svn info:

URL: svn+ssh://svn.mozilla.org/sysadmins/puppet/trunk/modules/productdelivery
Repository Root: svn+ssh://svn.mozilla.org/sysadmins
Repository UUID: 65d70b31-241a-0410-a745-f8fa14660ae9
Revision: 39712
Node Kind: directory
Schedule: normal
Last Changed Author: [e-mail]
Last Changed Rev: 39630
Last Changed Date: 2012-05-31 07:45:44 -0400 (Thu, 31 May 2012)

Comment 6

[Nick Thomas [:nthomas] (UTC+12)]

Might be a noob when it comes to add/delete/moving files in SVN. I used svn move to create get-rsync-module-size. You can do
  cp files/bin/{get-prereleases-size,get-rsync-module-size}
to apply the patch.

Comment 7

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 628965 [details] [diff] [review]
[svn] rework motd, v2

Committed revision 39924.