rsync-motd is broken for mozilla-releases and mozilla-current

RESOLVED FIXED

Status

P2
normal
RESOLVED FIXED
7 years ago
6 months ago

People

(Reporter: nthomas, Assigned: nthomas)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

7 years ago
I trimmed the modules today and it's still reporting
                     mozilla-releases: 132GB
                       mozilla-current: 31GB
(Assignee)

Comment 1

7 years ago
Created attachment 628634 [details] [diff] [review]
[svn] rework motd

Lots of historical cruft getting the chop here, in favour of doing rsync -n and parsing the lines like this:
 total size is 194350446326  speedup is 64600.04 (DRY RUN)
Attachment #628634 - Flags: review?(rail)
Comment on attachment 628634 [details] [diff] [review]
[svn] rework motd

Review of attachment 628634 [details] [diff] [review]:
-----------------------------------------------------------------

::: manifests/upload_cron.pp
@@ +55,2 @@
>              mode => 755,
>              source => "puppet:///modules/productdelivery/bin/get-prereleases-size";

I'm not sure if I understand this part.

It looks like you're removing get-prereleases-size in your patch (or trimming the file to 0, depending on how you apply the patch), but here you are trying to use the content of removed file...
(Assignee)

Comment 3

7 years ago
Created attachment 628965 [details] [diff] [review]
[svn] rework motd, v2

Good catch, this fixes that up.
Attachment #628634 - Attachment is obsolete: true
Attachment #628634 - Flags: review?(rail)
Attachment #628965 - Flags: review?(rail)
hmmm, I'm still getting errors trying to apply the patch:

$ svn co svn+ssh://svn.mozilla.org/sysadmins/puppet/trunk/modules/productdelivery
$ wget -O - https://bug760021.bugzilla.mozilla.org/attachment.cgi?id=628965 | patch -p0
patching file files/cron.d/motd-gen
patching file files/bin/get-prereleases-size
patching file files/bin/motd-gen.sh
can't find file to patch at input line 84
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|Index: files/bin/get-rsync-module-size
|===================================================================
|--- files/bin/get-rsync-module-size	(revision 39606)
|+++ files/bin/get-rsync-module-size	(working copy)
--------------------------
File to patch: 
Skip this patch? [y] 


Any ideas why it happens?
svn info:

URL: svn+ssh://svn.mozilla.org/sysadmins/puppet/trunk/modules/productdelivery
Repository Root: svn+ssh://svn.mozilla.org/sysadmins
Repository UUID: 65d70b31-241a-0410-a745-f8fa14660ae9
Revision: 39712
Node Kind: directory
Schedule: normal
Last Changed Author: catlee@mozilla.com
Last Changed Rev: 39630
Last Changed Date: 2012-05-31 07:45:44 -0400 (Thu, 31 May 2012)
(Assignee)

Comment 6

7 years ago
Might be a noob when it comes to add/delete/moving files in SVN. I used svn move to create get-rsync-module-size. You can do
  cp files/bin/{get-prereleases-size,get-rsync-module-size}
to apply the patch.
Attachment #628965 - Flags: review?(rail) → review+
(Assignee)

Comment 7

7 years ago
Comment on attachment 628965 [details] [diff] [review]
[svn] rework motd, v2

Committed revision 39924.
Attachment #628965 - Flags: checked-in+
(Assignee)

Updated

7 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
Component: General Automation → General
Product: Release Engineering → Release Engineering
You need to log in before you can comment on or make changes to this bug.