760107 - SUTAgent should support getting rotation

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[William Lachance (:wlach)]

For my new Orangatun project (https://github.com/wlach/orangatun), we need to be able to get the device's current rotation to figure out the transformation for drag gestures (since the raw events will always assume portrait mode).

Comment 1

[William Lachance (:wlach)]

Attachment: Patch to add support for getting device rotation to sutagent + devicemanager

This adds an info subcommand for getting device rotation.

Comment 2

[William Lachance (:wlach)]

Attachment: Minor follow-on patch to sut command client to allow showing rotation

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 628726 [details] [diff] [review]
Patch to add support for getting device rotation to sutagent + devicemanager

Review of attachment 628726 [details] [diff] [review]:
-----------------------------------------------------------------

overall this is good, just one question below.

::: build/mobile/sutagent/android/DoCommand.java
@@ +2305,5 @@
> +    public String GetRotationInfo()
> +        {
> +            WindowManager wMgr = (WindowManager) contextWrapper.getSystemService(Context.WINDOW_SERVICE);
> +            int nRotationDegrees = 0; // default
> +            switch(wMgr.getDefaultDisplay().getRotation())

is this available on all platforms?  I am asking mostly about the tegra (android 2.2), but we have seen tablets act differently as well.

Comment 4

[William Lachance (:wlach)]

(In reply to Joel Maher (:jmaher) from comment #3)

> is this available on all platforms?  I am asking mostly about the tegra
> (android 2.2), but we have seen tablets act differently as well.

Just tested on my LG G2X running 2.2. Works fine. I'll bet this even works on older devices...

Comment 5

[William Lachance (:wlach)]

Inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/7d6bfa12744d

(didn't mean to set target milestone above, oh well!)

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/7d6bfa12744d