Closed Bug 760223 Opened 12 years ago Closed 12 years ago

[TABLET] 'Find in page' and 'Request Desktop Site' need icons for the tablets / custom menu

Categories

(Firefox for Android Graveyard :: General, defect)

ARM
Android
defect
Not set
normal

Tracking

(firefox15 verified, firefox16 verified, firefox17 verified)

VERIFIED FIXED
Firefox 16
Tracking Status
firefox15 --- verified
firefox16 --- verified
firefox17 --- verified

People

(Reporter: sriram, Assigned: sriram)

References

Details

Attachments

(2 files)

"Find in Page" menu item is a tab specific menu item. Hence it needs an icon to be displayed in tablets and custom menu in ICS.

As it won't be showed in "5 + more" in pre-honeycomb devices, the respective icons can be removed to clean up apk.
Blocks: 760196
Blocks: find
This is the same for "Request Desktop Site". I hope it's okay to use this bug for both...
Blocks: 766406
Summary: [TABLET] Find in page needs an icon for the tablets / custom menu → [TABLET] 'Find in page' and 'Request Desktop Site' need icons for the tablets / custom menu
Attached file menu icons!
Here they are folks!
Attached patch PatchSplinter Review
This removes unnecessary icons in pre-honeycomb, as they won't be shown. This adds icons for honeycomb+. Some re-ordering in Makefile is also done.

Note: The icons existed in drawable/ and drawable-hdpi/ are very old, and if we end up having icons in pre-gingerbread, we should have bigger icons to be shown in "5+more" menu.

Anyways, when they are regrouped into sub menus, the sub menu display is a list and doesn't show icons.
Attachment #639729 - Flags: review?(mark.finkle)
Attachment #639729 - Flags: review?(mark.finkle) → review+
Is the Find in Page icon needed on Aurora for Firefox 15 too?
tracking-fennec: --- → ?
(In reply to Matt Brubeck (:mbrubeck) from comment #5)
> Is the Find in Page icon needed on Aurora for Firefox 15 too?

Yes, Find-in-Page is needed on Aurora. Request-Desktop is not on Aurora yet.
https://hg.mozilla.org/mozilla-central/rev/7d01ae75a5d7
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 16
Comment on attachment 639729 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): New icons added for these menu items.
User impact if declined: Menu won't have icons.
Testing completed (on m-c, etc.): Landed on m-c on 07/09
Risk to taking this patch (and alternatives if risky): None.
String or UUID changes made by this patch: None.
Attachment #639729 - Flags: approval-mozilla-aurora?
Attachment #639729 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assignee: nobody → sriram
Status: RESOLVED → VERIFIED
tracking-fennec: ? → ---
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: