760234 - URL bar should have orange highlight

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Sriram Ramasubramanian [:sriram]]

The newer designs for tablet URL bar in bug 739355, they have an orange highlight. This needs to be added for both tablets and phones.

Comment 1

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch (1/2): Orange highlight for tablet

This has the orange highlight just for the tablets.
Once we decide on having it for phones too (as a part of separate patch), the tablet based checks, and the GeckoStateListDrawable can be removed.

(This check might need to be added for the EditText in find-in-page, once that lands in central)

Comment 2

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch (1/2): Orange highlight for tablet

This is bit-trotted to be inbound ready. This applies the orange highlight for find-in-page too.

Comment 3

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch (2/2): Orange highlight for phone

This adds orange highlight for phones.
This removes the code for applying the highlight color on-the-go.

The "getHighlightColor()" can be removed, once the awesombar has newer tabs.

[Some tears for deleting the hardest hack I ever did: GeckoStateListDrawable.java]

** This needs clobbering **

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 628894 [details] [diff] [review]
Patch (1/2): Orange highlight for tablet

The isTablet changes drive me crazy, but thankfully those are removed in the next patch

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 628896 [details] [diff] [review]
Patch (2/2): Orange highlight for phone

>diff --git a/mobile/android/base/BrowserToolbar.java b/mobile/android/base/BrowserToolbar.java

>     public int getHighlightColor() {
>-        return mColor;
>+        return 0xFFFF9500;

Can we just remove this function altogether?

Comment 6

[Sriram Ramasubramanian [:sriram]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/7e16c8941d44
http://hg.mozilla.org/integration/mozilla-inbound/rev/bff1e8c1bc88

Fixed with removing getHighlightColor and mColor.

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/7e16c8941d44
https://hg.mozilla.org/mozilla-central/rev/bff1e8c1bc88

Comment 8

[Andreea Pod]

Verified using Samsung Galaxy Tab 10.1 (Android 3.1) and HTC Desire Z (Android 2.3) on:
Firefox 19.0b5 build 2 (2013-02-06), Nightly 21.0a1(2013-02-07) and Aurora 20.0a2(2013-02-07).