760256 - [traceback] IntegrityError: (1062, "Duplicate entry 'FDTesting (2)-9984' for key 'full_name_author_id'")

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Add-on Builder, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Sometimes when we run test_rename_addon, we get the following traceback (which happens when we POST to https://builder-addons-dev.allizom.org/addon/new/):

Traceback (most recent call last):

  File "/data/www/builder-addons-dev.allizom.org/flightdeck/vendor/lib/python/django/core/handlers/base.py", line 111, in get_response
    response = callback(request, *callback_args, **callback_kwargs)

  File "/data/www/builder-addons-dev.allizom.org/flightdeck/vendor/lib/python/django/contrib/auth/decorators.py", line 23, in _wrapped_view
    return view_func(request, *args, **kwargs)

  File "/data/www/builder-addons-dev.allizom.org/flightdeck/vendor/lib/python/django/db/transaction.py", line 217, in inner
    res = func(*args, **kwargs)

  File "/data/www/builder-addons-dev.allizom.org/flightdeck/apps/jetpack/views.py", line 988, in create
    item.save()

  File "/data/www/builder-addons-dev.allizom.org/flightdeck/apps/jetpack/models.py", line 1594, in save
    return self.save(iteration=iteration, **kwargs)

  File "/data/www/builder-addons-dev.allizom.org/flightdeck/apps/jetpack/models.py", line 1566, in save
    super(Package, self).save(**kwargs)

  File "/data/www/builder-addons-dev.allizom.org/flightdeck/apps/base/models.py", line 17, in save
    return super(BaseModel, self).save(**kwargs)

  File "/data/www/builder-addons-dev.allizom.org/flightdeck/vendor/lib/python/django/db/models/base.py", line 460, in save
    self.save_base(using=using, force_insert=force_insert, force_update=force_update)

  File "/data/www/builder-addons-dev.allizom.org/flightdeck/vendor/lib/python/django/db/models/base.py", line 553, in save_base
    result = manager._insert(values, return_id=update_pk, using=using)

  File "/data/www/builder-addons-dev.allizom.org/flightdeck/vendor/lib/python/django/db/models/manager.py", line 195, in _insert
    return insert_query(self.model, values, **kwargs)

  File "/data/www/builder-addons-dev.allizom.org/flightdeck/vendor/lib/python/django/db/models/query.py", line 1436, in insert_query
    return query.get_compiler(using=using).execute_sql(return_id)

  File "/data/www/builder-addons-dev.allizom.org/flightdeck/vendor/lib/python/django/db/models/sql/compiler.py", line 791, in execute_sql
    cursor = super(SQLInsertCompiler, self).execute_sql(None)

  File "/data/www/builder-addons-dev.allizom.org/flightdeck/vendor/lib/python/django/db/models/sql/compiler.py", line 735, in execute_sql
    cursor.execute(sql, params)

  File "/data/www/builder-addons-dev.allizom.org/flightdeck/vendor/lib/python/django/db/backends/mysql/base.py", line 86, in execute
    return self.cursor.execute(query, args)

  File "/usr/lib64/python2.6/site-packages/MySQLdb/cursors.py", line 173, in execute
    self.errorhandler(self, exc, value)

  File "/usr/lib64/python2.6/site-packages/MySQLdb/connections.py", line 36, in defaulterrorhandler
    raise errorclass, errorvalue

IntegrityError: (1062, "Duplicate entry 'FDTesting (2)-9984' for key 'full_name_author_id'")

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

test_rename_addon [1]:

def test_rename_addon(self, mozwebqa):
        homepage_obj = HomePage(mozwebqa)

        homepage_obj.go_to_home_page()
        loginpage_obj = homepage_obj.header.click_signin()
        dashboard_obj = loginpage_obj.login()

        new_addon_name = 'renamed addon ' + str(randint(1, 1000))

        #Create an addon.
        homepage_obj = dashboard_obj.go_to_home_page()
        addonpage_obj = homepage_obj.click_create_addon_btn()

        #Click properties and change its name
        addonpage_obj.click_properties()
        addonpage_obj.type_package_name(new_addon_name)
        addonpage_obj.click_properties_save()
        Assert.equal(addonpage_obj.package_name, new_addon_name)

        addonpage_obj.delete_test_data()

[1] https://github.com/mozilla/FlightDeck-selenium/blob/master/tests/test_addon_create.py#L44]

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

Fixed, I think, by https://github.com/mozilla/FlightDeck/commit/e1efb0f17060a1642c3b2c981f11c4327aa0326a and https://github.com/mozilla/FlightDeck/commit/c452f95d25b267f496ca904997ea990be4c9f993 ?

Our automation is happy, again!

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED -- thanks!