Last Comment Bug 760325 - content/media/test/test_timeupdate_small_files.html ran additional tests after finish() was called
: content/media/test/test_timeupdate_small_files.html ran additional tests afte...
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Audio/Video (show other bugs)
: Trunk
: x86_64 Linux
: -- normal (vote)
: mozilla15
Assigned To: Mats Palmgren (vacation)
:
Mentors:
Depends on: 760770 791105
Blocks: 759734
  Show dependency treegraph
 
Reported: 2012-05-31 16:52 PDT by Mats Palmgren (vacation)
Modified: 2012-09-13 14:58 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Report all events after 'ended' as test failures, except when removing the element we ignore timeupdate/pause/stalled events. Use info() for logging, not ok(). (3.19 KB, patch)
2012-05-31 17:00 PDT, Mats Palmgren (vacation)
roc: review+
Details | Diff | Splinter Review

Description Mats Palmgren (vacation) 2012-05-31 16:52:50 PDT
Fallout from the diagnostic patch in bug 677964.

The last three tests are after SimpleTest.finish() was called:

TEST-PASS | unknown test url | http://mochi.test:8888/tests/content/media/test/seek.webm got ended
TEST-PASS | unknown test url | [finished seek.webm-3] Length of array should match number of running tests - 0 should equal 0
TEST-INFO | unknown test url | Finished at Fri Jun 01 2012 01:21:10 GMT+0200 (CEST) (1338506470.241s)
TEST-INFO | unknown test url | Running time: 7.63s
TEST-PASS | unknown test url | http://mochi.test:8888/tests/content/media/test/seek.webm got timeupdate
TEST-PASS | unknown test url | http://mochi.test:8888/tests/content/media/test/seek.webm got pause
TEST-PASS | unknown test url | http://mochi.test:8888/tests/content/media/test/seek.webm got stalled
Comment 1 Mats Palmgren (vacation) 2012-05-31 17:00:41 PDT
Created attachment 628980 [details] [diff] [review]
Report all events after 'ended' as test failures, except when removing the element we ignore timeupdate/pause/stalled events.  Use info() for logging, not ok().

Assuming that timeupdate/pause/stalled while removing the element is OK?
Comment 2 Robert O'Callahan (:roc) (Exited; email my personal email if necessary) 2012-05-31 22:35:49 PDT
Comment on attachment 628980 [details] [diff] [review]
Report all events after 'ended' as test failures, except when removing the element we ignore timeupdate/pause/stalled events.  Use info() for logging, not ok().

Review of attachment 628980 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/media/test/test_timeupdate_small_files.html
@@ +55,5 @@
>  function logEvent(event) {
> +  if (event.target.gotEnded > (event.type == "ended" ? 1 : 0))
> +    ok(false, event.target.currentSrc + " got unexpected " + event.type + " after ended");
> +  else
> +    info(event.target.currentSrc + " got " + event.type);

{} around these bodies.
Comment 3 Mats Palmgren (vacation) 2012-06-01 11:47:12 PDT
https://tbpl.mozilla.org/?usebuildbot=1&tree=Try&rev=5db9663b5473

Note You need to log in before you can comment on or make changes to this bug.