content/media/test/test_timeupdate_small_files.html ran additional tests after finish() was called

RESOLVED FIXED in mozilla15

Status

()

Core
Audio/Video
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mats, Assigned: mats)

Tracking

Trunk
mozilla15
x86_64
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Fallout from the diagnostic patch in bug 677964.

The last three tests are after SimpleTest.finish() was called:

TEST-PASS | unknown test url | http://mochi.test:8888/tests/content/media/test/seek.webm got ended
TEST-PASS | unknown test url | [finished seek.webm-3] Length of array should match number of running tests - 0 should equal 0
TEST-INFO | unknown test url | Finished at Fri Jun 01 2012 01:21:10 GMT+0200 (CEST) (1338506470.241s)
TEST-INFO | unknown test url | Running time: 7.63s
TEST-PASS | unknown test url | http://mochi.test:8888/tests/content/media/test/seek.webm got timeupdate
TEST-PASS | unknown test url | http://mochi.test:8888/tests/content/media/test/seek.webm got pause
TEST-PASS | unknown test url | http://mochi.test:8888/tests/content/media/test/seek.webm got stalled
(Assignee)

Comment 1

5 years ago
Created attachment 628980 [details] [diff] [review]
Report all events after 'ended' as test failures, except when removing the element we ignore timeupdate/pause/stalled events.  Use info() for logging, not ok().

Assuming that timeupdate/pause/stalled while removing the element is OK?
Attachment #628980 - Flags: review?(roc)
Comment on attachment 628980 [details] [diff] [review]
Report all events after 'ended' as test failures, except when removing the element we ignore timeupdate/pause/stalled events.  Use info() for logging, not ok().

Review of attachment 628980 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/media/test/test_timeupdate_small_files.html
@@ +55,5 @@
>  function logEvent(event) {
> +  if (event.target.gotEnded > (event.type == "ended" ? 1 : 0))
> +    ok(false, event.target.currentSrc + " got unexpected " + event.type + " after ended");
> +  else
> +    info(event.target.currentSrc + " got " + event.type);

{} around these bodies.
Attachment #628980 - Flags: review?(roc) → review+
(Assignee)

Comment 3

5 years ago
https://tbpl.mozilla.org/?usebuildbot=1&tree=Try&rev=5db9663b5473
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/79b0b7c40b24
Target Milestone: --- → mozilla15
(Assignee)

Updated

5 years ago
Blocks: 759734
https://hg.mozilla.org/mozilla-central/rev/79b0b7c40b24
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Depends on: 760770

Updated

5 years ago
Depends on: 791105
You need to log in before you can comment on or make changes to this bug.