Closed Bug 760375 Opened 12 years ago Closed 12 years ago

Simplify code paths for moz installer by making dest argument mandatory

Categories

(Testing :: Mozbase, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: whimboo, Assigned: whimboo)

References

Details

Attachments

(1 file)

Right now we have too much magic in our code which is causing a lot of different code paths. Something we want to change is:

Making 'dest' a required argument - that will remove the guessing of a possible right installation directory. The consumer always has to specify the expected installation directory.
Attached file Patch v1
Pointer to Github pull-request
Attachment #629121 - Attachment description: Pointer to Github pull request: https://github.com/mozilla/mozbase/pull/17 → Patch v1
Attachment #629121 - Flags: review?(jhammel)
Comment on attachment 629121 [details]
Patch v1

lgtm
Attachment #629121 - Flags: review?(jhammel) → review+
Landed as:
https://github.com/mozilla/mozbase/commit/3487bd0bfdc85ab7bc127e16c5aff06f84804439
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Blocks: 762287
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: