Simplify code paths for moz installer by making dest argument mandatory

RESOLVED FIXED

Status

Testing
Mozbase
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: whimboo, Assigned: whimboo)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Right now we have too much magic in our code which is causing a lot of different code paths. Something we want to change is:

Making 'dest' a required argument - that will remove the guessing of a possible right installation directory. The consumer always has to specify the expected installation directory.
(Assignee)

Comment 1

6 years ago
Created attachment 629121 [details]
Patch v1

Pointer to Github pull-request
(Assignee)

Updated

6 years ago
Attachment #629121 - Attachment description: Pointer to Github pull request: https://github.com/mozilla/mozbase/pull/17 → Patch v1
Attachment #629121 - Flags: review?(jhammel)

Comment 2

6 years ago
Comment on attachment 629121 [details]
Patch v1

lgtm
Attachment #629121 - Flags: review?(jhammel) → review+
(Assignee)

Comment 3

6 years ago
Landed as:
https://github.com/mozilla/mozbase/commit/3487bd0bfdc85ab7bc127e16c5aff06f84804439
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(Assignee)

Updated

6 years ago
Blocks: 762287
You need to log in before you can comment on or make changes to this bug.