760604 - Custom menu should be able to handle change in showAsAction

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Sriram Ramasubramanian [:sriram]]

Currently the custom menu can only handle changing a normal menu item to action-bar item. It should be able to handle the reverse (just in case, we want to move back the items for want of space).
Also, the implementation has issues in removing. It cannot remove the action-bar items.

Comment 1

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

This patch fixes the following:
1. Removing of action-bar items is proper.
2. setShowAsAction can be changed dynamically.
3. For phones which doesn't support action-bar, the menu item stays with the usual menu display. (Say we expose addons to add the icon to the URL bar directly, the phones cannot have it, and it should stay with the normal menu).

Comment 2

[Sriram Ramasubramanian [:sriram]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/d71cabc2f4fa

Comment 3

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/d71cabc2f4fa