Closed Bug 760645 Opened 9 years ago Closed 9 years ago

Reader Mode: Update reader popup to match state of current url

Categories

(Firefox for Android Graveyard :: General, defect)

All
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 16

People

(Reporter: lucasr, Unassigned)

References

Details

Attachments

(4 files)

For instance we should probably disable or hide the "Add to Reading List" option if the current URL is already in the reading list. Madhava, Ian, any input here?
OS: Linux → Android
Hardware: x86 → All
To be honest, having played with your test build for a while I think we should try putting "Add to Reading List" somewhere else altogether, possibly in the overflow menu. Having to choose every time between 'Add to Reading List' and 'Reader Mode' is pretty irritating. 

So this would mean that tapping the book icon would always just switch to reader mode.

--

As an aside, I realize that we can't just keep stuffing things into our already huge menu like this, so I'm going to start thinking about how we can manage down that list a bit.
(In reply to Ian Barlow (:ibarlow) from comment #1)
> To be honest, having played with your test build for a while I think we
> should try putting "Add to Reading List" somewhere else altogether, possibly
> in the overflow menu. Having to choose every time between 'Add to Reading
> List' and 'Reader Mode' is pretty irritating. 
> 
> So this would mean that tapping the book icon would always just switch to
> reader mode.
> 
> --
> 
> As an aside, I realize that we can't just keep stuffing things into our
> already huge menu like this, so I'm going to start thinking about how we can
> manage down that list a bit.

Instead of the menu, why not add it to the reader itself? I guess we would lose the ability to add a page to the reader list without viewing first.

Note that if we added "Add to Reading List" to the menu, we would need to enable/disable it based on the ability to show the page in reader mode. I dislike having menu items that are disabled for many pages.
I dislike that too, a lot. 

Just thinking out loud, it might be worth considering rolling any "Add page to..." action into a single submenu. So instead of Share, Bookmark, and Add to Reading list, we might have a single menu item called Save or Add to... or something, that opens a secondary menu with sharing, reading list and bookmarking options.
Attachment #634951 - Flags: review?(mark.finkle)
Attachment #634948 - Flags: review?(mark.finkle) → review+
Attachment #634949 - Flags: review?(mark.finkle) → review+
Attachment #634950 - Flags: review?(mark.finkle) → review+
Attachment #634951 - Flags: review?(mark.finkle) → review+
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.