Closed
Bug 760645
Opened 13 years ago
Closed 13 years ago
Reader Mode: Update reader popup to match state of current url
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 16
People
(Reporter: lucasr, Unassigned)
References
Details
Attachments
(4 files)
7.66 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
7.37 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
15.30 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
41.00 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
For instance we should probably disable or hide the "Add to Reading List" option if the current URL is already in the reading list. Madhava, Ian, any input here?
Reporter | ||
Updated•13 years ago
|
OS: Linux → Android
Hardware: x86 → All
Comment 1•13 years ago
|
||
To be honest, having played with your test build for a while I think we should try putting "Add to Reading List" somewhere else altogether, possibly in the overflow menu. Having to choose every time between 'Add to Reading List' and 'Reader Mode' is pretty irritating.
So this would mean that tapping the book icon would always just switch to reader mode.
--
As an aside, I realize that we can't just keep stuffing things into our already huge menu like this, so I'm going to start thinking about how we can manage down that list a bit.
Comment 2•13 years ago
|
||
(In reply to Ian Barlow (:ibarlow) from comment #1)
> To be honest, having played with your test build for a while I think we
> should try putting "Add to Reading List" somewhere else altogether, possibly
> in the overflow menu. Having to choose every time between 'Add to Reading
> List' and 'Reader Mode' is pretty irritating.
>
> So this would mean that tapping the book icon would always just switch to
> reader mode.
>
> --
>
> As an aside, I realize that we can't just keep stuffing things into our
> already huge menu like this, so I'm going to start thinking about how we can
> manage down that list a bit.
Instead of the menu, why not add it to the reader itself? I guess we would lose the ability to add a page to the reader list without viewing first.
Note that if we added "Add to Reading List" to the menu, we would need to enable/disable it based on the ability to show the page in reader mode. I dislike having menu items that are disabled for many pages.
Comment 3•13 years ago
|
||
I dislike that too, a lot.
Just thinking out loud, it might be worth considering rolling any "Add page to..." action into a single submenu. So instead of Share, Bookmark, and Add to Reading list, we might have a single menu item called Save or Add to... or something, that opens a secondary menu with sharing, reading list and bookmarking options.
Reporter | ||
Comment 4•13 years ago
|
||
Attachment #634948 -
Flags: review?(mark.finkle)
Reporter | ||
Comment 5•13 years ago
|
||
Attachment #634949 -
Flags: review?(mark.finkle)
Reporter | ||
Comment 6•13 years ago
|
||
Attachment #634950 -
Flags: review?(mark.finkle)
Reporter | ||
Comment 7•13 years ago
|
||
Attachment #634951 -
Flags: review?(mark.finkle)
Updated•13 years ago
|
Attachment #634948 -
Flags: review?(mark.finkle) → review+
Updated•13 years ago
|
Attachment #634949 -
Flags: review?(mark.finkle) → review+
Updated•13 years ago
|
Attachment #634950 -
Flags: review?(mark.finkle) → review+
Updated•13 years ago
|
Attachment #634951 -
Flags: review?(mark.finkle) → review+
Reporter | ||
Comment 8•13 years ago
|
||
Comment 9•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/bca300e4459c
https://hg.mozilla.org/mozilla-central/rev/7e01c868ffdd
https://hg.mozilla.org/mozilla-central/rev/1f5b0566d955
https://hg.mozilla.org/mozilla-central/rev/32e5d236fd28
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 16
Assignee | ||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•