760645 - Reader Mode: Update reader popup to match state of current url

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Lucas Rocha (:lucasr)]

For instance we should probably disable or hide the "Add to Reading List" option if the current URL is already in the reading list. Madhava, Ian, any input here?

Comment 1

[Ian Barlow (:ibarlow)]

To be honest, having played with your test build for a while I think we should try putting "Add to Reading List" somewhere else altogether, possibly in the overflow menu. Having to choose every time between 'Add to Reading List' and 'Reader Mode' is pretty irritating. 

So this would mean that tapping the book icon would always just switch to reader mode.

--

As an aside, I realize that we can't just keep stuffing things into our already huge menu like this, so I'm going to start thinking about how we can manage down that list a bit.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Ian Barlow (:ibarlow) from comment #1)
> To be honest, having played with your test build for a while I think we
> should try putting "Add to Reading List" somewhere else altogether, possibly
> in the overflow menu. Having to choose every time between 'Add to Reading
> List' and 'Reader Mode' is pretty irritating. 
> 
> So this would mean that tapping the book icon would always just switch to
> reader mode.
> 
> --
> 
> As an aside, I realize that we can't just keep stuffing things into our
> already huge menu like this, so I'm going to start thinking about how we can
> manage down that list a bit.

Instead of the menu, why not add it to the reader itself? I guess we would lose the ability to add a page to the reader list without viewing first.

Note that if we added "Add to Reading List" to the menu, we would need to enable/disable it based on the ability to show the page in reader mode. I dislike having menu items that are disabled for many pages.

Comment 3

[Ian Barlow (:ibarlow)]

I dislike that too, a lot. 

Just thinking out loud, it might be worth considering rolling any "Add page to..." action into a single submenu. So instead of Share, Bookmark, and Add to Reading list, we might have a single menu item called Save or Add to... or something, that opens a secondary menu with sharing, reading list and bookmarking options.

Comment 4

[Lucas Rocha (:lucasr)]

Attachment: (1/4) Change reader button to go straight to Reader Mode

Comment 5

[Lucas Rocha (:lucasr)]

Attachment: (2/4) Add needed BrowserDB api to manage reading list

Comment 6

[Lucas Rocha (:lucasr)]

Attachment: (3/4) Update bookmarks icons to show yellow star when active

Comment 7

[Lucas Rocha (:lucasr)]

Attachment: (4/4) Add reading list app menu item

Comment 8

[Lucas Rocha (:lucasr)]

Pushed:
http://hg.mozilla.org/integration/mozilla-inbound/rev/bca300e4459c
http://hg.mozilla.org/integration/mozilla-inbound/rev/7e01c868ffdd
http://hg.mozilla.org/integration/mozilla-inbound/rev/1f5b0566d955
http://hg.mozilla.org/integration/mozilla-inbound/rev/32e5d236fd28

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/bca300e4459c
https://hg.mozilla.org/mozilla-central/rev/7e01c868ffdd
https://hg.mozilla.org/mozilla-central/rev/1f5b0566d955
https://hg.mozilla.org/mozilla-central/rev/32e5d236fd28