If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Remove all gaiamobile.org prefs from b2g.js

RESOLVED FIXED

Status

Firefox OS
General
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: fabrice, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
Created attachment 629387 [details] [diff] [review]
patch

We now add all these prefs in user.js as part as the gaia build process, so let's remove all these hardcoded domains from b2g.js
(Reporter)

Updated

5 years ago
Attachment #629387 - Flags: review?(21)
What about the builds on the jsconf phones? Do we have a graceful upgrade path for them?
(In reply to Philipp von Weitershausen [:philikon] from comment #1)
> What about the builds on the jsconf phones? Do we have a graceful upgrade
> path for them?

Nobody more than me wants to remove those prefs but the JSConf phones are going to be dead if this patch is pushed and Gecko is updated before Gaia.

Let's see what @cjones thinks about it.
Comment on attachment 629387 [details] [diff] [review]
patch

I'm fine with the code removal fwit, just unsure about the decision to make here so I would like Chris review before landing that.
Attachment #629387 - Flags: review?(jones.chris.g)
Attachment #629387 - Flags: review?(21)
Attachment #629387 - Flags: review+
Fabrice, how far away are we from being able to populate the permissions DB from app manifests at install time?  (If you know.)

I'm pretty loath to break JSConf phones.  If we're far away from a "real" fix here, I would prefer to split this gunk out into another file and conditionally include it for now.
(Reporter)

Comment 5

5 years ago
(In reply to Chris Jones [:cjones] [:warhammer] from comment #4)
> Fabrice, how far away are we from being able to populate the permissions DB
> from app manifests at install time?  (If you know.)

We haven't started on this yet.

> I'm pretty loath to break JSConf phones.  If we're far away from a "real"
> fix here, I would prefer to split this gunk out into another file and
> conditionally include it for now.

ok, I'll see what we can do to not break jsconf phones.
(In reply to Fabrice Desré [:fabrice] from comment #5)
> (In reply to Chris Jones [:cjones] [:warhammer] from comment #4)
> > Fabrice, how far away are we from being able to populate the permissions DB
> > from app manifests at install time?  (If you know.)
> 
> We haven't started on this yet.

Do we already have a permissions DB and just the filling is missing?
I can work on this if the plan is to use idb.
Any updates here?  I noticed my review request is still pending.

To reiterate, I'd r+ if these were conditionally included, until we have a better solution.
Comment on attachment 629387 [details] [diff] [review]
patch

What the hell.  We'll notice that something is broken if we don't find a better solution before attempting JSConf update.
Attachment #629387 - Flags: review?(jones.chris.g) → review+
(Reporter)

Comment 9

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/ec910f35ce86
https://hg.mozilla.org/mozilla-central/rev/ec910f35ce86
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.