760806 - Can't modify start and end date of an event in the datepicker with the keyboard, the value is reset when leaving the input field

Status: RESOLVED FIXED

(Calendar :: Dialogs, defect)

Description

[Ilja Sekler]

The input fields for the start and end date of an event or task in the datepicker can't be modified with the keyboard, the changes are discarded when tabbing away or clicking into another input field. To modify the date one has to open the minimonth and click on the desired date (the minimonth is not keyboard accessible).

This worked some time ago, but got broken AFAIR well before the recent big Lightning breakdown due to bug #650353.

The timepicker is not affected and behaves correctly.

Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/15.0 Thunderbird/15.0a1

c-c: 54380e539f1a
m-c: 7bf0125b26b5


STR:

1. Open the Edit Event or the New Event dialog.

2. Navigate to the input field for the Start or End date in the datepicker.

3. Overwrite the preexisting value with another valid value.

4. Press the tab key or click into another input field.


Actual Results:

The changes to the date are discarded.


Expected Results:

The datepicker retains the new value.


I can hardly believe that this issue hasn't been reported yet, but I failed searching for such a bug report.

Comment 1

[Stefan Sitter [:ssitter]]

Confirmed as regression.

Works for me using Lightning 1.6a2 (BuildID: 20120604091857) Mozilla/5.0 (Windows NT 6.1; WOW64; rv:14.0) Gecko/20120604 Thunderbird/14.0a2 (BuildID: 20120604042011)

Fails for me using Lightning 1.8a1 (custom build) with Mozilla/5.0 (Windows NT 6.1; WOW64; rv:16.0) Gecko/16.0 Thunderbird/16.0a1 (BuildID: 20120607030200)

Ilja, are you able to specify the regression range on Linux? I can't do it due to the lack of Windows nightly builds.

Comment 2

[Ilja Sekler]

> [...] got broken AFAIR well before the recent big Lightning breakdown [...]

I was very wrong here, this is a regression from Bug #751925. Reverting the patch in <http://hg.mozilla.org/comm-central/rev/ae4c74d92fd1> fixes the issue.

The final regression window was

works: 2012-05-23 c-c rev. 2666d5407c2b

fails: 2012-05-24 c-c rev. d0c13c84ee7e

Comment 3

[Stefan Sitter [:ssitter]]

Attachment: bustage fix

Revert to comparing numbers that is less strict than comparing strings. In the given example the day string could be e.g. "4" or "04" depending on the format string.

Comment 4

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 631971 [details] [diff] [review]
bustage fix

Thanks for the patch, r=philipp and approved for aurora

Comment 5

[Stefan Sitter [:ssitter]]

Pushed to https://hg.mozilla.org/comm-central/rev/57b50c3e3f75

Comment 6

[Stefan Sitter [:ssitter]]

Pushed to https://hg.mozilla.org/releases/comm-aurora/rev/d7d600c31a9b