[10.8] background.png needs to be resized for Mountain Lion

RESOLVED FIXED in Thunderbird 20.0

Status

defect
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Nomis101, Assigned: andreasn)

Tracking

unspecified
Thunderbird 20.0
x86
macOS
Dependency tree / graph

Thunderbird Tracking Flags

(thunderbird14-, thunderbird15-, thunderbird16+, thunderbird17-, thunderbird18+ fixed, thunderbird19 fixed, thunderbird-esr1718+ fixed)

Details

Attachments

(3 attachments, 3 obsolete attachments)

Reporter

Description

7 years ago
Same as Bug 736655 for Firefox. We also need to resize background.png for Thunderbird.
Reporter

Updated

7 years ago
Andreas: can you come up with a revised image (I think you did the original Mac ones), and I'll then find someone to do the dance to get the images into the dmg?
Assignee: nobody → nisses.mail
Assignee

Comment 2

7 years ago
I don't think I was the one who did the background (that I can remember), but I can reproduce it and upload a new one. What dimensions do we need specifically? Dimensions 451x295? Can I find this graphics in the source tree somewhere?
Reporter

Comment 3

7 years ago
The background.png for officialy branded TB should be /other-licenses/branding/thunderbird/background.png
The 10.8 modified background.png from Firefox now has 437x311px (opened with Preview and inspected into the Information window)
Reporter

Comment 4

7 years ago
Today I've tried the same for the Thunderbird background what Steven did in the Firefox bug [1] and increased the background to 437x311px. But I still had white margins on 10.8. So I've done a bit measurement with PS and increased the background to 453x322px. Now it looks perfect on 10.8. But now it doesn't look so good anymore on 10.7. :-/ So, what can we do?

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=736655#c9
Andreas, could you try taking a look at Nomis's comments. Ping me on irc if you need more mac thinking.
Assignee

Comment 6

7 years ago
I'll check it out. I have the graphics almost done sitting on my hard drive.
Assignee

Comment 7

7 years ago
Posted patch new graphics (obsolete) — Splinter Review
This should do the trick.
Assignee

Comment 8

7 years ago
Although I haven't tried it as I don't have a Mountain Lion install (yet, will do one tomorrow). I assume Firefox would have the same issues.
Nomis: does everything look all right in the Firefox installer?
Reporter

Comment 9

7 years ago
(In reply to Andreas Nilsson (:andreasn) from comment #8)
> Nomis: does everything look all right in the Firefox installer?
I'm not sure which version of FF should be fixed. I've tested FF 14.0.1 (official branding) and FF 17a1 (unofficial branding), which both have issues (light white border).
Assignee

Comment 10

7 years ago
hm, so creating a dmg gives me a window the size of 452x315 on Mountain Lion. Does anyone else get that? Do we have any parameters specifying the window dimensions?
(In reply to Andreas Nilsson (:andreasn) from comment #10)
> hm, so creating a dmg gives me a window the size of 452x315 on Mountain
> Lion. Does anyone else get that? Do we have any parameters specifying the
> window dimensions?

cc'ing some people who may be able to help.
Assignee

Comment 12

7 years ago
Posted patch installer graphics of 452x316 (obsolete) — Splinter Review
Mark also reported a initial window size of 452x316, so here is the patch for that.
Attachment #653193 - Attachment is obsolete: true
Attachment #680641 - Flags: ui-review?(bwinton)
Attachment #680641 - Flags: review?(mbanner)
Comment on attachment 680641 [details] [diff] [review]
installer graphics of 452x316

On Mac OS X 10.8.2 I get this:
https://dl.dropbox.com/u/2301433/Screenshots/SmallInstaller.png
which doesn't look quite right…  ;)

Thanks,
Blake.
Attachment #680641 - Flags: ui-review?(bwinton) → ui-review-
Assignee

Comment 14

7 years ago
Blake: I assume you're running Mountain Lion?
Assignee

Comment 15

7 years ago
Errr... you said what version you were running in the comment. Nevermind :)
Assignee

Comment 16

7 years ago
it seems Blake's window is 436x316px so the image size in the patch should be correct.
Assignee

Comment 17

7 years ago
Posted patch installer graphics in 72dpi (obsolete) — Splinter Review
Florian pointed out that when he fixed the Instantbird installer graphics the other day he had ran into a similar problem and was able to fix it by changing the dpi of the image from 90dpi to 72dpi. Looking at the Firefox installer graphics they also use 72dpi. The attached patch uses this dpi too, lets see if that does the trick.
Assignee

Comment 18

7 years ago
Here we go. Setting it to 70 DPI made the trick.
Attachment #680641 - Attachment is obsolete: true
Attachment #681031 - Attachment is obsolete: true
Attachment #680641 - Flags: review?(mbanner)
Assignee

Comment 19

7 years ago
If anyone on non-mountainlion-osx are able to try this out it would be great.
Reporter

Comment 20

7 years ago
This looks good for me on 10.8 and on 10.7. On 10.7 I only noticed, that the arrow between the application icon and the folder icon is shifted a bit to the folder icon (and not in the middle). Except from that, it looks good.
Assignee

Comment 21

7 years ago
the arrow shiftning I don't think there is much we can do about. Setting up for review.
Assignee

Updated

7 years ago
Attachment #681074 - Flags: ui-review?(bwinton)
Attachment #681074 - Flags: review?(mbanner)
Comment on attachment 681074 [details] [diff] [review]
installer graphics in 70dpi

If Blake's happy with this then so am I.
Attachment #681074 - Flags: review?(mbanner) → review+
Comment on attachment 681074 [details] [diff] [review]
installer graphics in 70dpi

I'm still getting strange results (https://dl.dropbox.com/u/2301433/Screenshots/InstallerOff.png), but I'm willing to believe that they're just my setup.  So, I'm going to say ui-r=me, on the condition of a try-build that doesn't show the problem I'm seeing.  ;)

Thanks,
Blake.
Attachment #681074 - Flags: ui-review?(bwinton) → ui-review+
Assignee

Comment 24

7 years ago
My own mercurial account seems to have been disabled due to inactivity, so Mike helped me push it https://hg.mozilla.org/try-comm-central/rev/cf6d02f7217f
Not perfect, but better than it was.  Let's ship it.
Assignee

Updated

7 years ago
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/7e707fcf81d3

Note that I had to back this out and re-land it due to me forgetting to set you as the patch author, Andreas. I've asked you before and I'll politely ask you again, please configure your hg so that your patches include that information to begin with. Thanks!
https://developer.mozilla.org/en-US/docs/Creating_a_patch_that_can_be_checked_in
Status: NEW → RESOLVED
Closed: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 20.0
Assignee

Comment 28

7 years ago
Ryan: Sorry about that. I was under the impression that my hgrc was correct now.

Filed bug #814044 about the icon position.
Comment on attachment 681074 [details] [diff] [review]
installer graphics in 70dpi

[Triage Comment]
Taking this forward onto branches for the next releases.
Attachment #681074 - Flags: approval-comm-esr17+
Attachment #681074 - Flags: approval-comm-beta+
Attachment #681074 - Flags: approval-comm-aurora+
You need to log in before you can comment on or make changes to this bug.