38.69 KB, image/jpeg
135.65 KB, patch
|Details | Diff | Splinter Review|
220.49 KB, image/png
Created attachment 629602 [details] Screenshot of the issue on 10.8 Same as Bug 736655 for Firefox. We also need to resize background.png for Thunderbird.
Andreas: can you come up with a revised image (I think you did the original Mac ones), and I'll then find someone to do the dance to get the images into the dmg?
Assignee: nobody → nisses.mail
tracking-thunderbird14: --- → +
I don't think I was the one who did the background (that I can remember), but I can reproduce it and upload a new one. What dimensions do we need specifically? Dimensions 451x295? Can I find this graphics in the source tree somewhere?
The background.png for officialy branded TB should be /other-licenses/branding/thunderbird/background.png The 10.8 modified background.png from Firefox now has 437x311px (opened with Preview and inspected into the Information window)
Today I've tried the same for the Thunderbird background what Steven did in the Firefox bug  and increased the background to 437x311px. But I still had white margins on 10.8. So I've done a bit measurement with PS and increased the background to 453x322px. Now it looks perfect on 10.8. But now it doesn't look so good anymore on 10.7. :-/ So, what can we do?  https://bugzilla.mozilla.org/show_bug.cgi?id=736655#c9
Andreas, could you try taking a look at Nomis's comments. Ping me on irc if you need more mac thinking.
tracking-thunderbird14: + → -
tracking-thunderbird15: --- → +
I'll check it out. I have the graphics almost done sitting on my hard drive.
Although I haven't tried it as I don't have a Mountain Lion install (yet, will do one tomorrow). I assume Firefox would have the same issues. Nomis: does everything look all right in the Firefox installer?
(In reply to Andreas Nilsson (:andreasn) from comment #8) > Nomis: does everything look all right in the Firefox installer? I'm not sure which version of FF should be fixed. I've tested FF 14.0.1 (official branding) and FF 17a1 (unofficial branding), which both have issues (light white border).
hm, so creating a dmg gives me a window the size of 452x315 on Mountain Lion. Does anyone else get that? Do we have any parameters specifying the window dimensions?
tracking-thunderbird15: + → -
tracking-thunderbird16: --- → +
(In reply to Andreas Nilsson (:andreasn) from comment #10) > hm, so creating a dmg gives me a window the size of 452x315 on Mountain > Lion. Does anyone else get that? Do we have any parameters specifying the > window dimensions? cc'ing some people who may be able to help.
tracking-thunderbird17: --- → +
Created attachment 680641 [details] [diff] [review] installer graphics of 452x316 Mark also reported a initial window size of 452x316, so here is the patch for that.
Comment on attachment 680641 [details] [diff] [review] installer graphics of 452x316 On Mac OS X 10.8.2 I get this: https://dl.dropbox.com/u/2301433/Screenshots/SmallInstaller.png which doesn't look quite right… ;) Thanks, Blake.
Attachment #680641 - Flags: ui-review?(bwinton) → ui-review-
Blake: I assume you're running Mountain Lion?
Errr... you said what version you were running in the comment. Nevermind :)
it seems Blake's window is 436x316px so the image size in the patch should be correct.
Created attachment 681031 [details] [diff] [review] installer graphics in 72dpi Florian pointed out that when he fixed the Instantbird installer graphics the other day he had ran into a similar problem and was able to fix it by changing the dpi of the image from 90dpi to 72dpi. Looking at the Firefox installer graphics they also use 72dpi. The attached patch uses this dpi too, lets see if that does the trick.
Created attachment 681074 [details] [diff] [review] installer graphics in 70dpi Here we go. Setting it to 70 DPI made the trick.
If anyone on non-mountainlion-osx are able to try this out it would be great.
This looks good for me on 10.8 and on 10.7. On 10.7 I only noticed, that the arrow between the application icon and the folder icon is shifted a bit to the folder icon (and not in the middle). Except from that, it looks good.
the arrow shiftning I don't think there is much we can do about. Setting up for review.
Comment on attachment 681074 [details] [diff] [review] installer graphics in 70dpi If Blake's happy with this then so am I.
Attachment #681074 - Flags: review?(mbanner) → review+
Comment on attachment 681074 [details] [diff] [review] installer graphics in 70dpi I'm still getting strange results (https://dl.dropbox.com/u/2301433/Screenshots/InstallerOff.png), but I'm willing to believe that they're just my setup. So, I'm going to say ui-r=me, on the condition of a try-build that doesn't show the problem I'm seeing. ;) Thanks, Blake.
Attachment #681074 - Flags: ui-review?(bwinton) → ui-review+
My own mercurial account seems to have been disabled due to inactivity, so Mike helped me push it https://hg.mozilla.org/try-comm-central/rev/cf6d02f7217f
Created attachment 683478 [details] 10.8 with patch Here's what I get on 10.8 with the try server build (available here: http://email@example.com/try-comm-central-macosx64/)
tracking-thunderbird17: + → -
tracking-thunderbird18: --- → +
tracking-thunderbird-esr17: --- → 18+
Not perfect, but better than it was. Let's ship it.
https://hg.mozilla.org/comm-central/rev/7e707fcf81d3 Note that I had to back this out and re-land it due to me forgetting to set you as the patch author, Andreas. I've asked you before and I'll politely ask you again, please configure your hg so that your patches include that information to begin with. Thanks! https://developer.mozilla.org/en-US/docs/Creating_a_patch_that_can_be_checked_in
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 20.0
Ryan: Sorry about that. I was under the impression that my hgrc was correct now. Filed bug #814044 about the icon position.
Comment on attachment 681074 [details] [diff] [review] installer graphics in 70dpi [Triage Comment] Taking this forward onto branches for the next releases.
https://hg.mozilla.org/releases/comm-aurora/rev/ea00d98ef193 https://hg.mozilla.org/releases/comm-beta/rev/742eaab54639 https://hg.mozilla.org/releases/comm-esr17/rev/2e1d71632906
status-thunderbird18: --- → fixed
status-thunderbird19: --- → fixed
status-thunderbird-esr17: --- → fixed
You need to log in before you can comment on or make changes to this bug.