760990 - Unlocalizable strings in app submission process

Status: RESOLVED FIXED

(Marketplace Graveyard :: General, defect)

Description

[Pavel Cvrcek [:JasnaPaka]]

I tried add new application and I found many strings which we cannot localize in this wizard.

* Step 2
- "Kick off things by creating your app's manifest and entering its URL below. Learn about manifests."

* Step 3
- "Device Types
    Desktop
    Mobile
    Tablet"
- "If your app has another homepage, enter its address here."
- "If your app has a support website or forum, enter its address here."
- "The email address used by end users to contact you with support issues and refund requests."

Payments

- "To sell your app in the Marketplace, you'll first need to set its price tier below. Price tiers are based on US Dollars and are fixed for all supported currencies. Learn more about price tiers
App Price *
When should your app be made available for sale?

    As soon as it is approved.
    Not until I manually make it public."

- "PayPal email address"

- "In order to process refunds you approve through the Marketplace, as well as automatic refunds described in our Refund Policy, we need refund access to your associated PayPal account. Please click the button below to be taken to PayPal to grant permissions.
Set up permissions"

Last step

- buttons "Manage My App" and "Submit Another App"

Comment 1

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/zamboni/commit/7cec919

(In reply to Pavel Cvrcek (Mozilla.cz) [:JasnaPaka] from comment #0)
> I tried add new application and I found many strings which we cannot
> localize in this wizard.
> 
> * Step 2
> - "Kick off things by creating your app's manifest and entering its URL
> below. Learn about manifests."

Fixed.

> * Step 3
> - "Device Types
>     Desktop
>     Mobile
>     Tablet"

The translations for these device types are stored in the DB. They were added here: https://github.com/mozilla/zamboni/blob/master/migrations/312-app-device-types.sql#L28

Let me know if you cannot localize them.

> - "If your app has another homepage, enter its address here."

This should already have been localizable: https://github.com/mozilla/zamboni/blob/master/mkt/submit/forms.py#L189

> - "If your app has a support website or forum, enter its address here."

This should already have been localizable: https://github.com/mozilla/zamboni/blob/master/mkt/submit/forms.py#L194

> - "The email address used by end users to contact you with support issues
> and refund requests."

This should already have been localizable: https://github.com/mozilla/zamboni/blob/master/mkt/submit/forms.py#L199

> Payments
> 
> - "To sell your app in the Marketplace, you'll first need to set its price
> tier below. Price tiers are based on US Dollars and are fixed for all
> supported currencies. Learn more about price tiers

Fixed.

> App Price *

This should already have been localizable: https://github.com/mozilla/zamboni/blob/master/mkt/submit/forms.py#L75 and https://github.com/mozilla/zamboni/blob/master/mkt/developers/forms.py#L384

> When should your app be made available for sale?

The "When should your app ..." bit should already have been localizable: https://github.com/mozilla/zamboni/blob/master/mkt/submit/forms.py#L80 

>     As soon as it is approved.

Already here: https://github.com/mozilla/zamboni/blob/master/mkt/site/forms.py#L14

>     Not until I manually make it public."

Already here: https://github.com/mozilla/zamboni/blob/master/mkt/site/forms.py#L15

> - "PayPal email address"

Fixed.

> - "In order to process refunds you approve through the Marketplace, as well
> as automatic refunds described in our Refund Policy, we need refund access
> to your associated PayPal account. Please click the button below to be taken
> to PayPal to grant permissions.
> Set up permissions"

Fixed.

> Last step
> 
> - buttons "Manage My App" and "Submit Another App"

Fixed.