Closed Bug 760999 Opened 9 years ago Closed 9 years ago

Intermittent browser_webconsole_netlogging.js | TypeError: content.wrappedJSObject.testXhrGet is not a function

Categories

(DevTools :: Console, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 16

People

(Reporter: rcampbell, Assigned: msucan)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webconsole/test/browser_webconsole_netlogging.js | an unexpected uncaught JS exception reported through window.onerror - TypeError: content.wrappedJSObject.testXhrGet is not a function at chrome://mochitests/content/browser/browser/devtools/webconsole/test/browser_webconsole_netlogging.js:101
Proposed fix.

Potential problem: the network request callback is invoked before the page completes loading, before testXhrGet() is available.

Solution: also wait for page load.

Try push:
https://tbpl.mozilla.org/?tree=Try&rev=3b7f99b34142
Assignee: nobody → mihai.sucan
Status: NEW → ASSIGNED
Attachment #629825 - Flags: review?(rcampbell)
Comment on attachment 629825 [details] [diff] [review]
[in-fx-team] proposed fix

yeah, I think that should cover it. I don't think you can have requestCallbackInvoked == false and still get your load event.
Attachment #629825 - Flags: review?(rcampbell) → review+
Comment on attachment 629825 [details] [diff] [review]
[in-fx-team] proposed fix

https://hg.mozilla.org/integration/fx-team/rev/51c36b7f783b
Attachment #629825 - Attachment description: proposed fix → [in-fx-team] proposed fix
Whiteboard: [fixed-in-fx-team]
Blocks: 438871
Whiteboard: [fixed-in-fx-team] → [orange][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/51c36b7f783b
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 16
Whiteboard: [orange][fixed-in-fx-team] → [orange]
Whiteboard: [orange]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.