Missing Opus export in glmedias.dll in mingw builds

RESOLVED FIXED in mozilla16

Status

()

Core
Audio/Video
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Jacek Caban, Assigned: Jacek Caban)

Tracking

Trunk
mozilla16
x86
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 629724 [details] [diff] [review]
fix v1.0

Bug 759612 introduced using more symbold from Opus that are not explicitly exported by symbold.def. It works on MSVC because __declspec(dllexport) is used there. While __declspec(dllexport) could work on mingw (it's a matter of changing Opus headers a bit), I think using symbols.def is a better idea.
Attachment #629724 - Flags: review?(kinetik)
Comment on attachment 629724 [details] [diff] [review]
fix v1.0

Thanks!
Attachment #629724 - Flags: review?(kinetik) → review+
Status: NEW → ASSIGNED
(Assignee)

Comment 2

5 years ago
Thanks for the quick review.

https://hg.mozilla.org/integration/mozilla-inbound/rev/b6067aa77360
Target Milestone: --- → mozilla15
Target Milestone: mozilla15 → mozilla16
https://hg.mozilla.org/mozilla-central/rev/b6067aa77360
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.