761119 - Multiple access keys used in preferences dialog for lij locale

Status: VERIFIED FIXED

(Mozilla Localizations :: lij / Ligurian, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Our Mozmill l10n tests have been shown that there are some access keys which are used multiple times in the same scope. The full list of those keys you can find here:

http://mozmill-ci.blargon7.com/#/l10n/report/fdec829b93b19c73985be1d388611a48

Details:

 accessKey: a found in strings: [id: (id is undefined), label: Agiùtto], [id: alwaysAsk, label: Domàndime sénpre dónde sarvâ i file]
accessKey: s found in strings: [id: useBookmark, label: Adêuvia o segnalìbbro…], [id: closeWhenDone, label: Særa quànde o descaregaménto o l'é finîo]
accessKey: b found in strings: [id: linkTargeting, label: Àrvi drénto nêuvo barcón], [id: showTabBar, label: Fànni védde sénpre a bâra di féuggi]
accessKey: a found in strings: [id: (id is undefined), label: Agiùtto], [id: advancedFonts, label: Avansæ…]
accessKey: e found in strings: [id: popupPolicyButton, label: Eceçioìn…], [id: (id is undefined), label: Eceçioìn…]
accessKey: s found in strings: [id: (id is undefined), label: (label is undefined)], [id: chooseLanguage, label: Çèrni…]
accessKey: a found in strings: [id: (id is undefined), label: Agiùtto], [id: useDocumentFonts, label: Permétti a-e pàgine de çèrne o seu caràtere invêce da mæ seleçión]
accessKey: c found in strings: [id: (id is undefined), label: (label is undefined)], [id: (id is undefined), label: (label is undefined)]
accessKey: s found in strings: [id: (id is undefined), label: (label is undefined)], [id: (id is undefined), label: (label is undefined)], [id: (id is undefined), label: (label is undefined)]
accessKey: a found in strings: [id: (id is undefined), label: Agiùtto], [id: useDocumentColors, label: Permétti a-e pàgine de çèrne i coî]
accessKey: s found in strings: [id: (id is undefined), label: (label is undefined)], [id: browserUseSystemColors, label: Adêuvia i coî de scistêma], [id: browserUnderlineAnchors, label: Sotolìnia colegaménti]
accessKey: d found in strings: [id: privacyDoNotTrackPrefs, label: Dìnni a-i scîti che mi no véuggio êse traciòu], [id: locationBarSuggestionLabel, label: (label is undefined)]
accessKey: d found in strings: [id: privacyDoNotTrackPrefs, label: Dìnni a-i scîti che mi no véuggio êse traciòu], [id: locationBarSuggestionLabel, label: (label is undefined)]
accessKey: a found in strings: [id: (id is undefined), label: Agiùtto], [id: acceptCookies, label: açetta i cookie da sti scîti]
accessKey: d found in strings: [id: privacyDoNotTrackPrefs, label: Dìnni a-i scîti che mi no véuggio êse traciòu], [id: locationBarSuggestionLabel, label: (label is undefined)]
accessKey: a found in strings: [id: (id is undefined), label: Agiùtto], [id: acceptCookies, label: açetta i cookie da sti scîti]
accessKey: d found in strings: [id: privacyDoNotTrackPrefs, label: Dìnni a-i scîti che mi no véuggio êse traciòu], [id: locationBarSuggestionLabel, label: (label is undefined)]
accessKey: a found in strings: [id: (id is undefined), label: Agiùtto], [id: warnAddonInstall, label: Avèrtime quàndo 'n scîto o prêuva a instalâ di conponénti azónti]
accessKey: b found in strings: [id: blockAttackSites, label: Blòcco pe-i scîti d'atàcco], [id: blockWebForgeries, label: Blòcco pe-e falsificaçioìn web]
accessKey: e found in strings: [id: addonExceptions, label: Eceçioìn…], [id: passwordExceptions, label: Eceçioìn…]
accessKey: p found in strings: [id: useMasterPassword, label: Adêuvia 'na paròlla segrétta prinçipâ], [id: showPasswords, label: Paròlle segrétte sarvæ…]
accessKey: s found in strings: [id: removePermission, label: Scancélla scîto], [id: (id is undefined), label: Særa]
accessKey: a found in strings: [id: (id is undefined), label: Agiùtto], [id: useAutoScroll, label: Adêuvia scoriménto aotomàtico]
accessKey: m found in strings: [id: useSmoothScrolling, label: Adêuvia scoriménto regolâ], [id: submitTelemetryBox, label: Manda informaçion in sciô fonçionamento]
accessKey: a found in strings: [id: (id is undefined), label: Agiùtto], [id: (id is undefined), label: URL pe inpostâ in aotomàtico o proxy:]
accessKey: a found in strings: [id: (id is undefined), label: Agiùtto], [id: (id is undefined), label: Instàlla i agiornaménti in aotomàtico (racomandòu: ciù seguéssa)], [id: useService, label: Uzâ 'n serviçio ascozo pe instalâ i agiornaménti]
accessKey: a found in strings: [id: (id is undefined), label: Agiùtto], [id: viewSecurityDevicesButton, label: Aparâti]
accessKey: l found in strings: [id: (id is undefined), label: Seleçiónn-a un in aotomàtico], [id: viewCRLButton, label: Lista de aboliçión]

Comment 1

[alessio]

Argh!!!!
I hope this resolve all:
http://hg.mozilla.org/releases/l10n/mozilla-aurora/lij/rev/6b873ee54287

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

It doesn't solve all the failures or new ones have been introduced:

http://mozmill-ci.blargon7.com/#/l10n/report/fdec829b93b19c73985be1d388637041

 accessKey: i found in strings: [id: loadImages, label: Càrega e inmàgini in aotomàtico], [id: chooseLanguage, label: Çèrni…]
accessKey: c found in strings: [id: (id is undefined), label: (label is undefined)], [id: (id is undefined), label: (label is undefined)]
accessKey: s found in strings: [id: (id is undefined), label: (label is undefined)], [id: (id is undefined), label: (label is undefined)], [id: (id is undefined), label: (label is undefined)]
accessKey: a found in strings: [id: (id is undefined), label: Agiùtto], [id: (id is undefined), label: Instàlla i agiornaménti in aotomàtico (racomandòu: ciù seguéssa)] 

If you want to check the results yourself, simply use the following URL some minutes after your check-in:

http://mozmill-ci.blargon7.com/#/l10n/reports

Comment 3

[alessio]

Ok I resolve all can I resolve.... But in this 2 point I can't understand where the error is: (it don't say the string to change!!)

accessKey: c found in strings: [id: (id is undefined), label: (label is undefined)], [id: (id is undefined), label: (label is undefined)]
{"lineNumber":180,"caller":{"lineNumber":209,"caller":{"lineNumber":0,"caller":{"lineNumber":77,"caller":{"lineNumber":0,"caller":{"lineNumber":125,"caller":{"lineNumber":431,"caller":{"lineNumber":0,"caller":{"lineNumber":107,"caller":{"lineNumber":0,"caller":null,"name":null,"filename":null},"name":"mdObserver_observe","filename":"resource://mozmill/stdlib/securable-module.js -> file:///tmp/tmpzfUUeN.mozmill-tests/lib/modal-dialog.js"},"name":null,"filename":null},"name":"DOMWalker_modalWindowHelper","filename":"resource://mozmill/stdlib/securable-module.js -> file:///tmp/tmpzfUUeN.mozmill-tests/lib/dom-utils.js"},"name":"DOMWalker_walk","filename":"resource://mozmill/stdlib/securable-module.js -> file:///tmp/tmpzfUUeN.mozmill-tests/lib/dom-utils.js"},"name":null,"filename":null},"name":"checkAccessKeysResults","filename":"resource://mozmill/stdlib/securable-module.js -> file:///tmp/tmpzfUUeN.mozmill-tests/lib/localization.js"},"name":null,"filename":null},"name":"Expect_fail","filename":"resource://mozmill/stdlib/securable-module.js -> file:///tmp/tmpzfUUeN.mozmill-tests/lib/assertions.js"},"name":"Expect__test","filename":"resource://mozmill/stdlib/securable-module.js -> file:///tmp/tmpzfUUeN.mozmill-tests/lib/assertions.js"}
accessKey: s found in strings: [id: (id is undefined), label: (label is undefined)], [id: (id is undefined), label: (label is undefined)], [id: (id is undefined), label: (label is undefined)]

Comment 4

[alessio]

I've made misteke in pasting:
so the error is this: but How can I correct it?

accessKey: c found in strings: [id: (id is undefined), label: (label is undefined)], [id: (id is undefined), label: (label is undefined)]

accessKey: s found in strings: [id: (id is undefined), label: (label is undefined)], [id: (id is undefined), label: (label is undefined)], [id: (id is undefined), label: (label is undefined)]

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

The easiest way to find this out is to run those tests locally on your machine and check the screenshots which are getting produced. Therefore install Mozmill Crowd: https://addons.mozilla.org/en-US/firefox/addon/mozmill-crowd/

Just run the l10n tests with the locale of Firefox you want to test and afterward check the mozmill-crowd/screenshots folder, where you can find images of all failures.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

We recently have landed a patch which makes those entries more descriptive. So that's what left here:

 accessKey: "c" found in: label[control=selectLangs][accesskey=C], value: Codìfica do caràtere predefinîa:
accessKey: "s" found in: label[control=serif][accesskey=S], label[control=monospace][accesskey=S], value: Dimensción: 

That should let you fix the problem.

Comment 7

[alessio]

Thanks!!!! Bug solved.... (on aurora)

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Interestingly we have detected a duplicate accesskey on Linux only. Is there a different configuration?

http://mozmill-ci.blargon7.com/#/l10n/report/ee284dfa9d664754a65676abbc05ccf8

 accessKey: "a" found in: button[label=Agiùtto], checkbox#warnIncompatible 

Otherwise it looks good and we should file a bug to get the cut-off elements fixed which can be seen in the above linked report.

Comment 9

[alessio]

mmm is very strange this duplicate... 
I don't find it on lang file. Cannot be an test error?

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: screenshot (remaining issue)

That's the screenshot made by the l1on testrun for the remaining issue.

Comment 11

[alessio]

Thanks for your attachment!
Now I think it's correct

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Yes! Now all issues have been fixed. Thanks a lot.

http://mozmill-ci.blargon7.com/#/l10n/reports