Closed Bug 76119 Opened 23 years ago Closed 23 years ago

Gif crashes Mozilla

Categories

(Core :: Graphics: ImageLib, defect, P1)

Product:
Core
Component:
Graphics: ImageLib
Platform:
x86
Windows 98
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla0.9.1

People

(Reporter: mozbug, Assigned: saari)

References

(
URL
)

Details

(Keywords: crash, Whiteboard: [imglib])

Attachments

(2 files)

Error reported from an image viewer
11.60 KB, image/gif
Details
Patch to fix crash
1.13 KB, patch
Details | Diff | Splinter Review 
2001041508 trunk win98

Load http://www.uri.sakura.ne.jp/~anc/images/space.gif
-> Page fault in imglib32.dll

Talkback ID soon
Severity: normal → critical
Keywords: crash
Small typo : page fault in imglib2.dll

TB29143489H

Dup of 74423?
I think the handling of an corrupted image (whether it's an JPG of GIF or other 
formats should get more robust.  Displaying a black block will give the user 
less frustration than just crashing.
jpeg and png have pretty solid error handling.  i'll look into this
i've added code to avoid the actual crash.. i'll fire assertions in the places 
where it would previouly crash.  handing over to saari to fix the conditions in 
the gif decoder that are causing it to (now) hit the assertions.
Assignee: pavlov → saari
*** Bug 57314 has been marked as a duplicate of this bug. ***
changing status to [imglib]
Whiteboard: [imglib]
*** Bug 75243 has been marked as a duplicate of this bug. ***
*** Bug 75284 has been marked as a duplicate of this bug. ***
*** Bug 74535 has been marked as a duplicate of this bug. ***
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.1
still crashes on Linux and Mac using today's bits.
Priority: -- → P1
Summary: http://www.uri.sakura.ne.jp/~anc/images/space.gif crashes Mozilla → Gif crashes Mozilla
Crashed too on 2001050104 win98
Talkback TB29877499K

    
    

    
  
r=, sr= needed

    
    

    
  
Fixed
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED

    
    

    
  
*** Bug 57314 has been marked as a duplicate of this bug. ***

    
    

    
  
Can't seem to get to image, verifying patch checked into lxr.mozilla.org
Status: RESOLVED → VERIFIED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: