761212 - Custom menu should scroll to top whenever it is shown

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Sriram Ramasubramanian [:sriram]]

Custom menu should scroll to top whenever it is shown. Currently only the visibility is changed for the menu.

Comment 1

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

This patch makes sure that the custom menu scrolls to top, whenever it is opened.
openOptionsMenu() gets called for non-h/w menu button devices. onMenuOpened() gets called for h/w menu button devices.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 629872 [details] [diff] [review]
Patch

ask for aurora approval too

Comment 3

[Sriram Ramasubramanian [:sriram]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/e7f9c105f6a2

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/e7f9c105f6a2

Comment 5

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 629872 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): -
User impact if declined: Custom menu will stay at the same position where it was left earlier. This is different from stock android's behavior.
Testing completed (on m-c, etc.): 06/06
Risk to taking this patch (and alternatives if risky): None.
String or UUID changes made by this patch: -

Comment 6

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 629872 [details] [diff] [review]
Patch

[Triage Comment]
No risk, go for it.

Comment 7

[Sriram Ramasubramanian [:sriram]]

Pushed to aurora:
https://hg.mozilla.org/releases/mozilla-aurora/rev/c22bed811ceb