Custom menu should scroll to top whenever it is shown. Currently only the visibility is changed for the menu.
Assignee: nobody → sriram
OS: Mac OS X → Android
Hardware: x86 → ARM
Created attachment 629872 [details] [diff] [review] Patch This patch makes sure that the custom menu scrolls to top, whenever it is opened. openOptionsMenu() gets called for non-h/w menu button devices. onMenuOpened() gets called for h/w menu button devices.
Attachment #629872 - Flags: review?(mark.finkle)
Comment on attachment 629872 [details] [diff] [review] Patch ask for aurora approval too
Attachment #629872 - Flags: review?(mark.finkle) → review+
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 16
Comment on attachment 629872 [details] [diff] [review] Patch [Approval Request Comment] Bug caused by (feature/regressing bug #): - User impact if declined: Custom menu will stay at the same position where it was left earlier. This is different from stock android's behavior. Testing completed (on m-c, etc.): 06/06 Risk to taking this patch (and alternatives if risky): None. String or UUID changes made by this patch: -
Attachment #629872 - Flags: approval-mozilla-aurora?
Comment on attachment 629872 [details] [diff] [review] Patch [Triage Comment] No risk, go for it.
Attachment #629872 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Pushed to aurora: https://hg.mozilla.org/releases/mozilla-aurora/rev/c22bed811ceb
Status: RESOLVED → VERIFIED
status-firefox15: fixed → verified
status-firefox16: --- → verified
status-firefox17: --- → verified
You need to log in before you can comment on or make changes to this bug.